Skip to content

Conversation

liuliu-dev
Copy link
Contributor

@liuliu-dev liuliu-dev commented Oct 3, 2025

Closes #6774, https://github.com/github/primer/issues/5908

This pull request makes significant updates to the deprecated ActionList component in @primer/react, focusing on removing the sx prop, eliminating styled-components usage, and migrating styles to CSS modules for better maintainability and performance. It also refactors related components (Group, Header, Divider, and Item) to use the new styling approach and updates their interfaces accordingly.

Changelog

New

  • ActionList and subcomponents wrappers for @primer/styled-react

Changed

  • move deprecated components to subfolder in @primer/styled-react

Removed

  • sx support from deprecated ActionList and subcomponents

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Oct 3, 2025

🦋 Changeset detected

Latest commit: 8bcca65

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 3, 2025
Copy link
Contributor

github-actions bot commented Oct 3, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-6944 October 6, 2025 23:20 Inactive
@github-actions github-actions bot requested a deployment to storybook-preview-6944 October 6, 2025 23:26 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6944 October 6, 2025 23:35 Inactive
@llastflowers llastflowers force-pushed the liuliu/removex-sx-in-deprecated-actionlist branch from 00e4fd1 to 1627f96 Compare October 6, 2025 23:46
@primer-integration
Copy link

🟢 ci completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Oct 6, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6944 October 6, 2025 23:52 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6944 October 7, 2025 00:00 Inactive
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 7, 2025
Copy link
Contributor

github-actions bot commented Oct 7, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 7, 2025
Copy link
Contributor

github-actions bot commented Oct 7, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@francinelucca francinelucca added this pull request to the merge queue Oct 7, 2025
Merged via the queue into main with commit 446956d Oct 7, 2025
44 checks passed
@francinelucca francinelucca deleted the liuliu/removex-sx-in-deprecated-actionlist branch October 7, 2025 00:30
@primer primer bot mentioned this pull request Oct 6, 2025
pksjce pushed a commit that referenced this pull request Oct 7, 2025
…deprecated (#6944)

Co-authored-by: Marie Lucca <[email protected]>
Co-authored-by: Marie Lucca <[email protected]>
Co-authored-by: llastflowers <[email protected]>
Co-authored-by: Brittany L. Houtz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for sx from the ActionList component in @primer/react/deprecated
4 participants