-
Notifications
You must be signed in to change notification settings - Fork 638
Remove BoxWithFallback usage and sx
prop from DataTable.Container
#6930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: e19f345 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the sx
prop support from DataTable.Container
as part of a larger effort to modernize the component architecture. The change replaces BoxWithFallback
usage with a modern polymorphic component pattern.
- Removes
sx
prop andBoxWithFallback
dependency fromDataTable.Container
- Implements modern polymorphic component pattern with
PolymorphicProps
- Updates type definitions to support generic
as
prop for element customization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/react/src/DataTable/Table.tsx | Removes sx prop support, replaces BoxWithFallback with polymorphic component pattern |
.changeset/fruity-monkeys-cover.md | Documents breaking change for major version release |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
… into mp/rm-boxwithfallback-table
fixes silly mistakes
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/3735 |
🟢 ci completed with status |
Relates to https://github.com/github/primer/issues/5424
Changelog
New
Changed
Removes
sx
prop fromDataTable.Container
Removed
Rollout strategy
Testing & Reviewing
Merge checklist