Skip to content

Conversation

mperrotti
Copy link
Contributor

Relates to https://github.com/github/primer/issues/5424

Changelog

New

Changed

Removes sx prop from DataTable.Container

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@mperrotti mperrotti requested a review from a team as a code owner September 30, 2025 21:51
Copy link

changeset-bot bot commented Sep 30, 2025

🦋 Changeset detected

Latest commit: e19f345

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the sx prop support from DataTable.Container as part of a larger effort to modernize the component architecture. The change replaces BoxWithFallback usage with a modern polymorphic component pattern.

  • Removes sx prop and BoxWithFallback dependency from DataTable.Container
  • Implements modern polymorphic component pattern with PolymorphicProps
  • Updates type definitions to support generic as prop for element customization

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/react/src/DataTable/Table.tsx Removes sx prop support, replaces BoxWithFallback with polymorphic component pattern
.changeset/fruity-monkeys-cover.md Documents breaking change for major version release

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 30, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/3735

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 2, 2025
@primer-integration
Copy link

🟢 ci completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Oct 2, 2025
@francinelucca francinelucca added this pull request to the merge queue Oct 6, 2025
Merged via the queue into main with commit 260c74c Oct 6, 2025
42 checks passed
@francinelucca francinelucca deleted the mp/rm-boxwithfallback-table branch October 6, 2025 17:15
@primer primer bot mentioned this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants