Skip to content

Conversation

llastflowers
Copy link
Contributor

@llastflowers llastflowers commented Sep 29, 2025

Closes #6757

Current sx usage: 7

sx usages are only in repos other than github-ui; those usages have been added to the tracking issue

Changelog

Removed

Remove support for sx from the ActionList component, and any sub-components, associated stories, docs, and tests

Rollout strategy

  • Major release; if selected, include a written rollout or migration plan

This component currently has 0 sx usage in dotcom, and therefore does not need the @primer/styled-react wrapper. this will be confirmed again before merging.

Merge checklist

Copy link

changeset-bot bot commented Sep 29, 2025

🦋 Changeset detected

Latest commit: 8e30feb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@llastflowers llastflowers self-assigned this Sep 29, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 29, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot requested a deployment to storybook-preview-6921 September 29, 2025 19:04 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6921 September 29, 2025 19:17 Inactive
@github-actions github-actions bot requested a deployment to storybook-preview-6921 September 29, 2025 23:22 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6921 September 29, 2025 23:30 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6921 September 30, 2025 01:39 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6921 September 30, 2025 01:55 Inactive
@github-actions github-actions bot requested a deployment to storybook-preview-6921 September 30, 2025 02:46 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6921 September 30, 2025 02:54 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6921 September 30, 2025 18:45 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6921 September 30, 2025 19:03 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6921 September 30, 2025 19:25 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6921 October 1, 2025 16:06 Inactive
@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 6, 2025
Copy link
Contributor

github-actions bot commented Oct 6, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 6, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6921 October 6, 2025 16:00 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh labels Oct 6, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6921 October 6, 2025 17:11 Inactive
@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Oct 6, 2025
@primer-integration
Copy link

🟢 ci completed with status success.

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 6, 2025
Copy link
Contributor

github-actions bot commented Oct 6, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@francinelucca francinelucca added this pull request to the merge queue Oct 6, 2025
Merged via the queue into main with commit c58f171 Oct 6, 2025
42 checks passed
@francinelucca francinelucca deleted the llastflowers/6757/rm-sx-ActionList2 branch October 6, 2025 20:17
@primer primer bot mentioned this pull request Oct 6, 2025
@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 6, 2025
pksjce pushed a commit that referenced this pull request Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for sx from the ActionList component
4 participants