Skip to content

Conversation

@liuliu-dev
Copy link
Contributor

@liuliu-dev liuliu-dev commented Sep 4, 2025

Wait until this PR is merged in github-ui: https://github.com/github/github-ui/pull/3366

Closes #5830

sx usage

Changelog

Removed

Removed sx props and Box from Text.

Rollout strategy

  • Major release; if selected, include a written rollout or migration plan

@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2025

🦋 Changeset detected

Latest commit: 16a5344

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-6729 September 4, 2025 23:46 Inactive
@liuliu-dev liuliu-dev closed this Sep 10, 2025
@liuliu-dev liuliu-dev deleted the liuliu/remove-sx-from-text branch September 10, 2025 20:21
@liuliu-dev liuliu-dev restored the liuliu/remove-sx-from-text branch September 19, 2025 17:08
@liuliu-dev liuliu-dev reopened this Sep 19, 2025
@github-actions github-actions bot requested a deployment to storybook-preview-6729 September 19, 2025 20:20 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6729 September 19, 2025 20:31 Inactive
@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 30, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6729 September 30, 2025 22:24 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh labels Sep 30, 2025
@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/3600

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Oct 1, 2025
@primer-integration
Copy link

🟢 ci completed with status success.

@francinelucca francinelucca changed the title DO NOT MERGE: Remove support for sx and Box usage from the Text component Remove support for sx and Box usage from the Text component Oct 1, 2025
@francinelucca francinelucca added this pull request to the merge queue Oct 1, 2025
Merged via the queue into main with commit 7ae5db2 Oct 1, 2025
43 of 45 checks passed
@francinelucca francinelucca deleted the liuliu/remove-sx-from-text branch October 1, 2025 13:20
@primer primer bot mentioned this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants