-
Notifications
You must be signed in to change notification settings - Fork 640
Remove support for sx
from FormControl
component
#6681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: e81d299 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
…rol' into liuliu/formcontrol-sx-removal
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/3429 |
🟢 ci completed with status |
Closes https://github.com/github/primer/issues/5794
Closes https://github.com/github/primer/issues/5909
Current
sx
usage: 160Changelog
Removed
Remove support for
sx
from theFormControl
component, and associated stories, docs, and testsRollout strategy
We are using the
@primer/styled-react
component to mitigate removingsx
usage. We will make sure usage is updated upstream before merging.Merge checklist