You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR migrates the KeybindingHint component tests from Jest to Vitest as part of the ongoing test suite migration effort.
Changes Made
Updated vitest.config.browser.mts: Added src/KeybindingHint/**/*.test.?(c|m)[jt]s?(x) to the include configuration
Updated jest.config.js: Added <rootDir>/src/KeybindingHint/ to the modulePathIgnorePatterns to exclude from Jest
Updated KeybindingHint.test.tsx: Added Vitest imports (describe, expect, it) while keeping the existing @testing-library/react imports
Validation
✅ All 19 tests pass with Vitest
✅ Jest no longer picks up these tests (correctly excluded)
✅ No deprecated functions were present (behavesAsComponent, checkExports, toHaveNoViolations, setupMatchMedia)
✅ Code formatting and linting pass
The migration was straightforward as the KeybindingHint tests were already using best practices with @testing-library/react and didn't rely on any Jest-specific functionality that needed to be removed.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
the
integration-tests: recommended
This PR migrates the KeybindingHint component tests from Jest to Vitest as part of the ongoing test suite migration effort.
Changes Made
vitest.config.browser.mts: Addedsrc/KeybindingHint/**/*.test.?(c|m)[jt]s?(x)to the include configurationjest.config.js: Added<rootDir>/src/KeybindingHint/to the modulePathIgnorePatterns to exclude from JestKeybindingHint.test.tsx: Added Vitest imports (describe,expect,it) while keeping the existing@testing-library/reactimportsValidation
The migration was straightforward as the KeybindingHint tests were already using best practices with
@testing-library/reactand didn't rely on any Jest-specific functionality that needed to be removed.Fixes #6387.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.