-
Notifications
You must be signed in to change notification settings - Fork 646
Add comments explaining dual close button implementation #6376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds explanatory comments to the SelectPanel component to document why there are two different close button implementations. The changes address issue #6352 by clarifying the dual close button approach used for different responsive behaviors.
- Adds detailed multi-line comment explaining the two close button implementations in SelectPanel.tsx
- Updates CSS comments to be more concise and removes outdated TODO about feature flag removal
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/react/src/SelectPanel/SelectPanel.tsx | Adds comprehensive comment explaining dual close button implementation and their use cases |
| packages/react/src/SelectPanel/SelectPanel.module.css | Simplifies header comment and removes outdated TODO about feature flag |
| } | ||
|
|
||
| /* | ||
| * Align SelectPanel header text with AnchoredOverlay close button |
Copilot
AI
Jul 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing article 'the' before 'SelectPanel'. Should be 'Align the SelectPanel header text with the AnchoredOverlay close button'
| * Align SelectPanel header text with AnchoredOverlay close button | |
| * Align the SelectPanel header text with the AnchoredOverlay close button |
Closes #6352
Adds code comments to explain why
SelectPanel has two close button implementations and when each is used.Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist