Skip to content

Conversation

@liuliu-dev
Copy link
Contributor

Closes #6352

Adds code comments to explain why SelectPanel has two close button implementations and when each is used.

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; This PR only adds comments for documentation purposes and does not change any functionality.

Testing & Reviewing

Merge checklist

@liuliu-dev liuliu-dev added the skip changeset This change does not need a changelog label Jul 24, 2025
@changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2025

⚠️ No Changeset found

Latest commit: 841cd45

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 24, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.21 KB (0%)
packages/react/dist/browser.umd.js 92.39 KB (0%)

@liuliu-dev liuliu-dev added the integration-tests: skipped manually Changes in this PR do not require an integration test label Jul 24, 2025
@liuliu-dev liuliu-dev requested a review from francinelucca July 24, 2025 16:26
@liuliu-dev liuliu-dev marked this pull request as ready for review July 24, 2025 16:27
Copilot AI review requested due to automatic review settings July 24, 2025 16:27
@liuliu-dev liuliu-dev requested a review from a team as a code owner July 24, 2025 16:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds explanatory comments to the SelectPanel component to document why there are two different close button implementations. The changes address issue #6352 by clarifying the dual close button approach used for different responsive behaviors.

  • Adds detailed multi-line comment explaining the two close button implementations in SelectPanel.tsx
  • Updates CSS comments to be more concise and removes outdated TODO about feature flag removal

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/react/src/SelectPanel/SelectPanel.tsx Adds comprehensive comment explaining dual close button implementation and their use cases
packages/react/src/SelectPanel/SelectPanel.module.css Simplifies header comment and removes outdated TODO about feature flag

}

/*
* Align SelectPanel header text with AnchoredOverlay close button
Copy link

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing article 'the' before 'SelectPanel'. Should be 'Align the SelectPanel header text with the AnchoredOverlay close button'

Suggested change
* Align SelectPanel header text with AnchoredOverlay close button
* Align the SelectPanel header text with the AnchoredOverlay close button

Copilot uses AI. Check for mistakes.
@liuliu-dev liuliu-dev added this pull request to the merge queue Jul 25, 2025
Merged via the queue into main with commit dbf4dbf Jul 25, 2025
53 checks passed
@liuliu-dev liuliu-dev deleted the liuliu/update-close-button-comments branch July 25, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consolidate SelectPanel close button implementation after fullscreen on narrow feature flag removal

3 participants