-
Notifications
You must be signed in to change notification settings - Fork 645
SelectPanel Select all feature
#6329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SelectPanel Select all feature
#6329
Conversation
…, and create new SelectPanel story WithSelectAll where this new feature is visible
…ndeterminate state for checkbox
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
🦋 Changeset detectedLatest commit: c404a19 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Add new opt-in `Select all` feature for SelectPanel
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/391216 |
|
🟢 golden-jobs completed with status |
packages/react/src/FilteredActionList/FilteredActionListWithDeprecatedActionList.tsx
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
This comment was marked as duplicate.
packages/react/src/FilteredActionList/FilteredActionList.module.css
Outdated
Show resolved
Hide resolved
langermank
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a non blocking suggestion but could easily be a followup!
This comment was marked as duplicate.
This comment was marked as duplicate.
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
Closes https://github.com/github/primer/issues/5348
Changelog
New
Select allsection with checkbox in SelectPanelSelect allcheckbox selects all filtered itemsSelect allboxSelect alllabel changes toDeselect allwhen all items are selectedDeselect allcheckbox deselects all filtered itemsindeterminatecheckbox stateSelect allcheckbox inindeterminatestate selects all remaining filtered itemsWith Select Allstory for SelectPanelChanged
N/A
Removed
N/A
Rollout strategy
Testing & Reviewing
Preview Link
This feature is designed to visually match the ModernActionList version of SelectPanel, so please toggle that feature flag on in Storybook when testing. (It still works without the FF, but just looks a bit goofy with the old SelectPanel design).
Merge checklist