Skip to content

Conversation

@llastflowers
Copy link
Contributor

@llastflowers llastflowers commented Jul 16, 2025

Closes https://github.com/github/primer/issues/5348

Changelog

New

  • Added Select all section with checkbox in SelectPanel
    • Select all checkbox selects all filtered items
    • Manually selecting all items automatically checks Select all box
    • Select all label changes to Deselect all when all items are selected
    • Deselect all checkbox deselects all filtered items
    • Manually checking some items but not all results in indeterminate checkbox state
    • Clicking Select all checkbox in indeterminate state selects all remaining filtered items
  • Added With Select All story for SelectPanel
  • Added new story to e2e
  • Added unit tests

Changed

N/A

Removed

N/A

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Preview Link

This feature is designed to visually match the ModernActionList version of SelectPanel, so please toggle that feature flag on in Storybook when testing. (It still works without the FF, but just looks a bit goofy with the old SelectPanel design).

Merge checklist

@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 16, 2025
@changeset-bot
Copy link

changeset-bot bot commented Jul 16, 2025

🦋 Changeset detected

Latest commit: c404a19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.26 KB (+0.32% 🔺)
packages/react/dist/browser.umd.js 92.35 KB (+0.15% 🔺)

@github-actions github-actions bot requested a deployment to storybook-preview-6329 July 16, 2025 19:43 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6329 July 16, 2025 19:52 Inactive
Add new opt-in `Select all` feature for SelectPanel
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/391216

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 16, 2025
@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Jul 16, 2025
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 17, 2025
@github-actions

This comment was marked as duplicate.

@github-actions github-actions bot requested a deployment to storybook-preview-6329 July 22, 2025 19:02 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6329 July 22, 2025 19:11 Inactive
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a non blocking suggestion but could easily be a followup!

@github-actions

This comment was marked as duplicate.

@github-actions github-actions bot temporarily deployed to storybook-preview-6329 July 22, 2025 21:01 Inactive
@llastflowers llastflowers added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 22, 2025
@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 22, 2025
@github-actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 22, 2025
@github-actions

This comment was marked as duplicate.

@llastflowers llastflowers added this pull request to the merge queue Jul 22, 2025
Merged via the queue into main with commit 14d6afd Jul 22, 2025
43 checks passed
@llastflowers llastflowers deleted the llastflowers/5348/SelectPanel-select-all-feature branch July 22, 2025 21:53
@primer primer bot mentioned this pull request Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants