Skip to content

chore(ActionList): Remove the CSS modules feature flag from the ActionList.Group component #6023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 9, 2025
Merged

chore(ActionList): Remove the CSS modules feature flag from the ActionList.Group component #6023

merged 4 commits into from
May 9, 2025

Conversation

@jonrohan
Copy link
Member

@jonrohan jonrohan commented May 7, 2025

Closes https://github.com/github/primer/issues/5171

Changelog

New

Changed

Removed

Remove the CSS modules feature flag from the ActionList.Group component

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented May 7, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: c5e20ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels May 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.08 KB (+0.06% 🔺)
packages/react/dist/browser.umd.js 97.31 KB (-0.19% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-6023 May 7, 2025 21:28 Inactive
@primer-integration
Copy link

primer-integration bot commented May 8, 2025

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/377006

@github-actions github-actions bot temporarily deployed to storybook-preview-6023 May 8, 2025 18:22 Inactive
@jonrohan jonrohan marked this pull request as ready for review May 8, 2025 18:38
Copilot AI review requested due to automatic review settings May 8, 2025 18:38
@jonrohan jonrohan requested a review from a team as a code owner May 8, 2025 18:39
@jonrohan jonrohan requested a review from TylerJDev May 8, 2025 18:39
@jonrohan jonrohan enabled auto-merge May 8, 2025 18:39
@primer-integration
Copy link

primer-integration bot commented May 8, 2025

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels May 8, 2025
Copilot AI reviewed May 8, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Remove the CSS modules feature flag from the ActionList.Group component and streamline its implementation.

  • Always render Group using BoxWithFallback and CSS modules (no runtime flag branches)
  • Define new .Group and .GroupList styles in Group.module.css
  • Refresh NavList snapshot tests to match updated class names
  • Add a changeset for a minor release

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/react/src/NavList/snapshots/NavList.test.tsx.snap Updated snapshot to reflect new CSS module class names
packages/react/src/ActionList/Group.tsx Removed feature-flag branches, replaced Box with BoxWithFallback
packages/react/src/ActionList/Group.module.css Added .Group and .GroupList selectors, removed old flag styles
.changeset/fair-hands-glow.md Created changeset for minor version bump

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label May 9, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6023 May 9, 2025 15:29 Inactive
@jonrohan jonrohan requested a review from joshblack May 9, 2025 16:49
@jonrohan jonrohan added this pull request to the merge queue May 9, 2025
@jonrohan jonrohan removed this pull request from the merge queue due to a manual request May 9, 2025
@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label May 9, 2025
@jonrohan jonrohan enabled auto-merge May 9, 2025 17:39
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label May 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@jonrohan jonrohan added this pull request to the merge queue May 9, 2025
Merged via the queue into main with commit 5e514f3 May 9, 2025
35 checks passed
@jonrohan jonrohan deleted the css_modules_remove_flag/actionlist_group branch May 9, 2025 18:02
@primer primer bot mentioned this pull request May 9, 2025
Merged
hectahertz pushed a commit that referenced this pull request May 20, 2025
@jonrohan @primer @hectahertz
chore(ActionList): Remove the CSS modules feature flag from the Actio…
4b71428 
…nList.Group component (#6023)

Co-authored-by: primer[bot] <119360173+primer[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@joshblack joshblack joshblack approved these changes

@TylerJDev TylerJDev Awaiting requested review from TylerJDev TylerJDev is a code owner automatically assigned from primer/engineer-reviewers

Assignees

No one assigned

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonrohan @joshblack