-
Notifications
You must be signed in to change notification settings - Fork 645
refactor(Flash): update sx usage to CSS Modules #6007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 85067e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the Flash component to use CSS Modules instead of sx and styled-components, and updates the component implementation to leverage BoxWithFallback.
- Removed
styled-componentsandstyled-systemvariants - Added
Flash.module.csswith equivalent styles using CSS Modules and data attributes - Updated
Flash.tsxto render aBoxWithFallbackwith CSS class and data attributes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/react/src/Flash/Flash.tsx | Refactored component to use BoxWithFallback and CSS Modules, removed sx usage |
| packages/react/src/Flash/Flash.module.css | Added CSS Module definitions for variant and layout styles |
| .changeset/giant-bushes-matter.md | Minor release changeset noting the refactor |
size-limit report 📦
|
jonrohan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good, just needs the CSS lint fixes
Update the
Flashcomponent from sx to CSS Modules. This change is not behind a feature flag since we're in the process of removing our GA flags.Changelog
New
Changed
sxusage of Flash internally to use CSS Modules insteadRemoved
Rollout strategy