Skip to content

fix(TextArea): only add class name to outermost element #5995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2025
Merged

fix(TextArea): only add class name to outermost element #5995

merged 3 commits into from
May 5, 2025

Conversation

@joshblack
Copy link
Member

@joshblack joshblack commented May 2, 2025 •
edited
Loading

Update TextArea to only add class name to outermost element

Changelog

New

Changed

  • Update TextArea to only add class name to outermost element

Removed

Rollout strategy

  • Patch release

@changeset-bot
Copy link

changeset-bot bot commented May 2, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: cd4d69c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels May 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

francinelucca
francinelucca approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.89 KB (-0.05% 🔽)
packages/react/dist/browser.umd.js 99.11 KB (+0.04% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5995 May 2, 2025 15:48 Inactive
@francinelucca francinelucca marked this pull request as ready for review May 5, 2025 16:12
@francinelucca francinelucca requested a review from a team as a code owner May 5, 2025 16:12
@francinelucca francinelucca requested a review from hectahertz May 5, 2025 16:12
@github-actions github-actions bot temporarily deployed to storybook-preview-5995 May 5, 2025 16:26 Inactive
@joshblack joshblack enabled auto-merge May 5, 2025 17:06
@francinelucca francinelucca disabled auto-merge May 5, 2025 21:14
@francinelucca francinelucca added this pull request to the merge queue May 5, 2025
Merged via the queue into main with commit 48909e4 May 5, 2025
45 checks passed
@francinelucca francinelucca deleted the joshblack-patch-1 branch May 5, 2025 21:58
@primer primer bot mentioned this pull request May 5, 2025
Merged
hectahertz pushed a commit that referenced this pull request May 20, 2025
@joshblack @francinelucca @hectahertz
fix(TextArea): only add class name to outermost element (#5995)
1a22e42 
Co-authored-by: Marie Lucca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@francinelucca francinelucca francinelucca approved these changes

@hectahertz hectahertz Awaiting requested review from hectahertz hectahertz is a code owner automatically assigned from primer/engineer-reviewers

Assignees

No one assigned

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshblack @francinelucca