chore(TextInput): Remove the CSS modules feature flag from the TextInput component

[jonrohan]

Closes https://github.com/github/primer/issues/4365

Changelog

New

Changed

Removed

Remove the CSS modules feature flag from the TextInput component

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

[changeset-bot]

🦋 Changeset detected

Latest commit: d48e4d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

[github-actions]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	101.63 KB (-1.03% 🔽)
packages/react/dist/browser.umd.js	102.05 KB (-0.74% 🔽)

[primer-integration]

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/374840

[primer-integration]

🟢 golden-jobs completed with status success.

[Copilot]

Pull Request Overview

This PR removes the CSS modules feature flag from the TextInput component and related subcomponents in order to simplify the implementation and remove conditional styling logic. Key changes include replacing toggled styled components with direct usage of BoxWithFallback or native elements, removing feature flag usage in inner visual and action components, and updating tests to reflect these changes.

Reviewed Changes

Copilot reviewed 12 out of 15 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
packages/react/src/internal/components/UnstyledTextInput.tsx	Removed feature flag logic and now always uses BoxWithFallback with CSS Modules.
packages/react/src/internal/components/TextInputWrapper.tsx	Simplified styling by removing conditional styled components and merging inline style props.
packages/react/src/internal/components/TextInputInnerVisualSlot.tsx	Removed feature flag usage and streamlined the spinner/visual slot structure.
packages/react/src/internal/components/TextInputInnerAction.tsx	Eliminated conditional style props based on feature flag, now using a consistent style for invisible controls.
packages/react/src/tests/*	Updated/removes tests that relied on feature flag behavior (with some tests skipped).
packages/react/src/TextInputWithTokens/TextInputWithTokens.tsx	Removed feature flag usage and replaced Box usage with native elements and CSS modules accordingly.
.changeset/empty-cooks-love.md	Documented the removal of the CSS modules feature flag.

Files not reviewed (3)

• packages/react/src/TextInputWithTokens/TextInputWithTokens.module.css: Language not supported
• packages/react/src/internal/components/TextInputInnerAction.module.css: Language not supported
• packages/react/src/internal/components/TextInputInnerVisualSlot.module.css: Language not supported

Comments suppressed due to low confidence (3)

packages/react/src/internal/components/TextInputWrapper.tsx:75

• Verify that merging inline style props in this conditional statement preserves the intended precedence of user-supplied styles, especially for width-related properties.

style={ typeof width === 'string' || typeof minWidth === 'string' || typeof maxWidth === 'string' ? {width, maxWidth, minWidth, ...style} : style }

packages/react/src/tests/Textarea.test.tsx:66

• The test for the optional block prop is now skipped; confirm that this prop is either deprecated or covered elsewhere to ensure adequate test coverage.

it.skip('renders an optional block prop correctly', () => {

packages/react/src/TextInputWithTokens/TextInputWithTokens.tsx:282

• Switching from the Box component to a native div changes the element semantics; please verify that all associated layout and style behaviors continue to work as expected.

<div className={styles.Container} data-prevent-token-wrapping={preventTokenWrapping}>