Skip to content

Adds className prop to UnderlineNav component. #5931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2025
Merged

Adds className prop to UnderlineNav component. #5931

merged 2 commits into from
Apr 16, 2025

Conversation

@jamieshark
Copy link
Contributor

@jamieshark jamieshark commented Apr 16, 2025 •
edited
Loading

Changelog

New

  • Adds className prop to UnderlineNav

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@jamieshark jamieshark requested a review from a team as a code owner April 16, 2025 17:36
@jamieshark jamieshark requested a review from jonrohan April 16, 2025 17:36
@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2025

⚠️ No Changeset found

Latest commit: db3c99a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jamieshark jamieshark self-assigned this Apr 16, 2025
@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

jonrohan
jonrohan approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡

@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.71 KB (+0.06% 🔺)
packages/react/dist/browser.umd.js 102.97 KB (+0.02% 🔺)

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.71 KB (+0.06% 🔺)
packages/react/dist/browser.umd.js 102.97 KB (+0.02% 🔺)

@jonrohan jonrohan enabled auto-merge April 16, 2025 17:40
@github-actions github-actions bot requested a deployment to storybook-preview-5931 April 16, 2025 17:40 Abandoned
@jonrohan jonrohan added this pull request to the merge queue Apr 16, 2025
Merged via the queue into main with commit 96af0aa Apr 16, 2025
45 checks passed
@jonrohan jonrohan deleted the jshark/underline-nav-clx branch April 16, 2025 18:03
@primer primer bot mentioned this pull request Apr 16, 2025
Merged
hectahertz pushed a commit that referenced this pull request May 20, 2025
@jamieshark @hectahertz
Adds className prop to UnderlineNav component. (#5931)
ebf453d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonrohan jonrohan jonrohan approved these changes

Assignees

@jamieshark jamieshark

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UnderlineNav doesn't accept className prop

3 participants

@jamieshark @jonrohan