Skip to content

chore(SideNav): Remove the CSS modules feature flag from the SideNav component #5876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2025
Merged

chore(SideNav): Remove the CSS modules feature flag from the SideNav component #5876

merged 2 commits into from
Apr 4, 2025

Conversation

@jonrohan
Copy link
Member

@jonrohan jonrohan commented Apr 3, 2025 •
edited
Loading

Closes #

Changelog

New

Changed

Removed

Remove the CSS modules feature flag from the SideNav component

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: c21b36a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Apr 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104 KB (-0.28% 🔽)
packages/react/dist/browser.umd.js 104.42 KB (-0.29% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-5876 April 3, 2025 22:43 Inactive
@primer-integration
Copy link

primer-integration bot commented Apr 3, 2025

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/371352

@primer-integration
Copy link

primer-integration bot commented Apr 3, 2025

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 3, 2025
@jonrohan jonrohan marked this pull request as ready for review April 3, 2025 23:34
@jonrohan jonrohan requested a review from a team as a code owner April 3, 2025 23:34
@jonrohan jonrohan requested a review from TylerJDev April 3, 2025 23:34
@jonrohan jonrohan enabled auto-merge April 3, 2025 23:34
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@jonrohan jonrohan added this pull request to the merge queue Apr 4, 2025
Merged via the queue into main with commit a78c820 Apr 4, 2025
42 of 43 checks passed
@jonrohan jonrohan deleted the remove_css_modules_flag_sidenav branch April 4, 2025 16:16
@primer primer bot mentioned this pull request Apr 4, 2025
Merged
jonrohan added a commit that referenced this pull request Apr 10, 2025
@jonrohan
chore(SideNav): Remove the CSS modules feature flag from the SideNav …
62cfae1 
…component (#5876)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblack joshblack joshblack approved these changes

@TylerJDev TylerJDev Awaiting requested review from TylerJDev TylerJDev is a code owner automatically assigned from primer/engineer-reviewers

Assignees

No one assigned

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonrohan @joshblack