Skip to content

Revert "Add workaround for Chrome bug where KeybindingHint in combination with aria-labelledby results in incorrect label" #5839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2025
Merged

Revert "Add workaround for Chrome bug where KeybindingHint in combination with aria-labelledby results in incorrect label" #5839

merged 3 commits into from
Mar 31, 2025

Conversation

@francinelucca
Copy link
Member

@francinelucca francinelucca commented Mar 29, 2025 •
edited
Loading

Reverts #5818

Main integration CI is currently red, looks like this PR contributed to some of the errors, seeing less errors in this revert than in main

@changeset-bot
Copy link

changeset-bot bot commented Mar 29, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: e56ba43

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Mar 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.36 KB (-0.01% 🔽)
packages/react/dist/browser.umd.js 105.8 KB (+0.07% 🔺)

@primer-integration
Copy link

primer-integration bot commented Mar 29, 2025

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/370189

@github-actions github-actions bot temporarily deployed to storybook-preview-5839 March 29, 2025 04:31 Inactive
@primer-integration
Copy link

primer-integration bot commented Mar 29, 2025

🔴 golden-jobs completed with status failure.

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Mar 29, 2025
@francinelucca francinelucca added the skip changeset This change does not need a changelog label Mar 29, 2025
@francinelucca francinelucca marked this pull request as ready for review March 29, 2025 04:49
@francinelucca francinelucca requested a review from a team as a code owner March 29, 2025 04:49
@francinelucca francinelucca requested a review from TylerJDev March 29, 2025 04:49
@francinelucca francinelucca added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Mar 29, 2025
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 29, 2025
@francinelucca francinelucca changed the title TEST: Revert "Add workaround for Chrome bug where KeybindingHint in combination with aria-labelledby results in incorrect label" Revert "Add workaround for Chrome bug where KeybindingHint in combination with aria-labelledby results in incorrect label" Mar 31, 2025
@francinelucca francinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 31, 2025
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 31, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5839 March 31, 2025 15:24 Inactive
@francinelucca francinelucca added this pull request to the merge queue Mar 31, 2025
@francinelucca francinelucca removed this pull request from the merge queue due to a manual request Mar 31, 2025
@francinelucca francinelucca added this pull request to the merge queue Mar 31, 2025
Merged via the queue into main with commit eb134ce Mar 31, 2025
44 checks passed
@francinelucca francinelucca deleted the revert-5818-keybindinghint-labelledby-bug branch March 31, 2025 16:03
@iansan5653 iansan5653 mentioned this pull request Mar 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblack joshblack joshblack approved these changes

@TylerJDev TylerJDev Awaiting requested review from TylerJDev TylerJDev is a code owner automatically assigned from primer/engineer-reviewers

Assignees

No one assigned

Labels

integration-tests: failing Changes in this PR cause breaking changes in gh/gh skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@francinelucca @joshblack