Skip to content

Overlay: Fix position for fullscreen overlay on narrow screens #5835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 31, 2025
Merged

Overlay: Fix position for fullscreen overlay on narrow screens #5835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9f9dbf3
full screen overlay should be fixed to top:0
siddharthkp Mar 28, 2025
0af5120
update snapshot
siddharthkp Mar 28, 2025
14f720d
Create light-beds-stare.md
siddharthkp Mar 28, 2025
523d6b4
Merge branch 'main' into overlay-fullscreen-fixed
francinelucca Mar 31, 2025
38f3cf7
Merge branch 'main' into overlay-fullscreen-fixed
francinelucca Mar 31, 2025
382191d
Merge branch 'main' into overlay-fullscreen-fixed
francinelucca Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/light-beds-stare.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Overlay: Fix position for fullscreen overlay on narrow screens
1 change: 1 addition & 0 deletions packages/react/src/Overlay/Overlay.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@
}

&:where([data-variant='fullscreen']) {
position: fixed;
top: 0;
left: 0;
width: 100vw;
Expand Down
1 change: 1 addition & 0 deletions packages/react/src/Overlay/Overlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ const StyledOverlay = toggleStyledComponent(
}

&:where([data-variant='fullscreen']) {
position: fixed;
top: 0;
left: 0;
width: 100vw;
Expand Down
1 change: 1 addition & 0 deletions packages/react/src/__tests__/__snapshots__/AnchoredOverlay.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ exports[`AnchoredOverlay should render consistently when open 1`] = `
}

.c1:where([data-variant='fullscreen']) {
position: fixed;
top: 0;
left: 0;
width: 100vw;
Expand Down
Loading