Skip to content

Conversation

@francinelucca
Copy link
Member

@francinelucca francinelucca commented Mar 27, 2025

Relates to https://github.com/github/primer/issues/4109

Changelog

Puts SelectPanel's fullscreen, save, cancel and close button functionality behind new Feature Flag

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@francinelucca francinelucca requested a review from a team as a code owner March 27, 2025 21:58
@francinelucca francinelucca requested a review from TylerJDev March 27, 2025 21:58
@changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2025

🦋 Changeset detected

Latest commit: 238e7bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Mar 27, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.64 KB (+0.08% 🔺)
packages/react/dist/browser.umd.js 106.06 KB (+0.13% 🔺)

@github-actions github-actions bot requested a deployment to storybook-preview-5832 March 27, 2025 22:03 Abandoned
@TylerJDev TylerJDev added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 27, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5832 March 27, 2025 22:15 Inactive
@primer primer bot requested a review from a team as a code owner March 27, 2025 22:22
@primer primer bot requested a review from mperrotti March 27, 2025 22:22
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 27, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5832 March 27, 2025 22:35 Inactive
@francinelucca francinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 27, 2025
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 27, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5832 March 27, 2025 22:49 Inactive
@TylerJDev TylerJDev merged commit b6c7690 into main Mar 27, 2025
44 checks passed
@TylerJDev TylerJDev deleted the fix/selectpanel-add-feature-flag branch March 27, 2025 23:05
@primer primer bot mentioned this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants