Skip to content

Conversation

@TylerJDev
Copy link
Member

@TylerJDev TylerJDev commented Mar 22, 2025

Moves the DialogOverflowWrapper class outside of .Backdrop. This ensures that the style flex-grow is properly applied to the container.

Additional context for this PR.

Changelog

Changed

  • Moves class DialogOverflowWrapper, so that it is no longer a child of the .Backdrop class

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2025

🦋 Changeset detected

Latest commit: 846dbd7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Mar 22, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.39 KB (-0.09% 🔽)
packages/react/dist/browser.umd.js 105.83 KB (-0.03% 🔽)

@TylerJDev TylerJDev marked this pull request as ready for review March 24, 2025 20:17
@TylerJDev TylerJDev requested a review from a team as a code owner March 24, 2025 20:17
@TylerJDev TylerJDev requested a review from hectahertz March 24, 2025 20:17
@github-actions github-actions bot temporarily deployed to storybook-preview-5811 March 24, 2025 20:30 Inactive
@TylerJDev TylerJDev added this pull request to the merge queue Mar 25, 2025
@TylerJDev TylerJDev removed this pull request from the merge queue due to a manual request Mar 26, 2025
@TylerJDev TylerJDev added this pull request to the merge queue Mar 26, 2025
Merged via the queue into main with commit 91b52f7 Mar 26, 2025
44 checks passed
@TylerJDev TylerJDev deleted the tylerjdev/fix-dialog-overflow-flex-issue branch March 26, 2025 00:30
@primer primer bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants