add missing className props and update behavesAsComponent test check #5810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 368ed02 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
integration-tests: recommended
Contributor
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
Contributor
size-limit report 📦
|
siddharthkp
reviewed
Mar 22, 2025
siddharthkp
approved these changes
Mar 22, 2025
Member
siddharthkp
left a comment
siddharthkp
left a comment
There was a problem hiding this comment.
Looks great! ❤️
Only feedback I have is on the changeset, approving in advance!
Co-authored-by: Siddharth Kshetrapal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
New
Changed
I noticed that
ActionList.Groupwas missing className so I decided to add it. I also added a test forActionListsub-components to ensure they all supportclassName. Then I realized we could updatebehavesAsComponentto do the check wherever it is being used. While doing so, it causing a few places that were missing displayName and className, which I also updatedclassNameprop to components missing themdisplayNameto components missing themActionListsub-componentsbehavesAsComponentto test for classNameskipClassNameto component checks that require wrapper to render or do not support itRemoved
Rollout strategy
Testing & Reviewing
Merge checklist