Skip to content

Conversation

@mperrotti
Copy link
Contributor

Unblocks https://github.com/github/primer-docs/pull/403

Latest release still gives an error:

hook.js:608 ReferenceError: aria is not defined
    at _createMdxContent (eval at MDXRemote.useMemo[Content] (index.js:1:1), <anonymous>:13:193)
    at MDXContent (eval at MDXRemote.useMemo[Content] (index.js:1:1), <anonymous>:34:14)
    at react-stack-bottom-frame (react-dom-client.development.js:23610:20)
    at renderWithHooks (react-dom-client.development.js:4646:22)
    at updateFunctionComponent (react-dom-client.development.js:8032:19)
    at beginWork (react-dom-client.development.js:9689:18)
    at runWithFiberInDEV (react-dom-client.development.js:544:16)
    at performUnitOfWork (react-dom-client.development.js:15064:22)
    at workLoopSync (react-dom-client.development.js:14888:41)
    at renderRootSync (react-dom-client.development.js:14868:11)
    at performWorkOnRoot (react-dom-client.development.js:14394:44)
    at performWorkOnRootViaSchedulerTask (react-dom-client.development.js:15955:7)
    at MessagePort.performWorkUntilDeadline (scheduler.development.js:44:48)

The above error occurred in the <MDXContent> component. It was handled by the <ErrorBoundaryHandler> error boundary. Error Component Stack
    at MDXContent (eval at MDXRemote.useMemo[Content] (index.js:1:1), <anonymous>:22:8)
    at MDXProvider (index.js:75:18)
    at MDXRemote (index.js:21:11)
    at InlineMDX (InlineMDX.tsx:6:36)
 ....

@mperrotti mperrotti requested a review from a team as a code owner March 21, 2025 19:14
@mperrotti mperrotti requested a review from jonrohan March 21, 2025 19:14
@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2025

⚠️ No Changeset found

Latest commit: 9467f8f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mperrotti mperrotti added the skip changeset This change does not need a changelog label Mar 21, 2025
@mperrotti mperrotti marked this pull request as draft March 21, 2025 19:17
@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.38 KB (0%)
packages/react/dist/browser.umd.js 105.74 KB (0%)

@mperrotti mperrotti changed the title Removes '$' from UnderlineNav aria-label description Fix Markdown UnderlineNav component API docs Mar 21, 2025
@github-actions github-actions bot requested a deployment to storybook-preview-5808 March 21, 2025 19:24 Abandoned
@mperrotti mperrotti added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit a279f14 Mar 25, 2025
44 checks passed
@mperrotti mperrotti deleted the mp/more-underlinenav-doc-fixes branch March 25, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants