Remove the CSS modules feature flag from the FormControl component #5807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4ce62ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
github-actions
bot
added
the
integration-tests: recommended
Contributor
size-limit report 📦
|
hussam-i-am
reviewed
Mar 24, 2025
…les_remove_flag_formcontrol
hussam-i-am
approved these changes
Mar 26, 2025
Contributor
hussam-i-am
left a comment
hussam-i-am
left a comment
There was a problem hiding this comment.
Awesome cleanup, love toggleSxComponent, maybe we can start moving the other components that already have the flag removed to using it as well.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
hectahertz
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the CSS modules feature flag from the
FormControlcomponent. The component FormControl is used 509 times in dotcom.Changelog
New
Changed
Removed
Removes the CSS modules feature flag from the FormControl component.
Rollout strategy
Testing & Reviewing
Merge checklist