Skip to content

Conversation

@jonrohan
Copy link
Member

@jonrohan jonrohan commented Mar 18, 2025

This PR removes the CSS modules feature flag from the ConfirmationDialog component. The component ConfirmationDialog is used 12 times in dotcom.

Changelog

New

Changed

Removed

Removes the CSS modules feature flag from the ConfirmationDialog components.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Using Integration testing.

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2025

🦋 Changeset detected

Latest commit: e31b852

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Mar 18, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 18, 2025
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.64 KB (-0.25% 🔽)
packages/react/dist/browser.umd.js 106.06 KB (-0.08% 🔽)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/367865

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Mar 18, 2025
@jonrohan jonrohan marked this pull request as ready for review March 18, 2025 23:44
@jonrohan jonrohan requested a review from a team as a code owner March 18, 2025 23:44
@jonrohan jonrohan requested a review from TylerJDev March 18, 2025 23:44
@jonrohan jonrohan added this pull request to the merge queue Mar 20, 2025
Merged via the queue into main with commit 1555b1b Mar 20, 2025
49 checks passed
@jonrohan jonrohan deleted the css_modules_remove_flag_confirmationdialog branch March 20, 2025 21:17
@primer primer bot mentioned this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants