Skip to content

Conversation

@hectahertz
Copy link
Contributor

@hectahertz hectahertz commented Mar 18, 2025

Closes https://github.com/github/primer/issues/4114

Changelog

New

Adds the notice prop to SelectPanel that renders an info/warning/error message to the user.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Screenshot of the info notice Screenshot of the warning notice Screenshot of the error notice

Merge checklist

@hectahertz hectahertz requested a review from a team as a code owner March 18, 2025 18:45
@hectahertz hectahertz requested a review from siddharthkp March 18, 2025 18:45
@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2025

🦋 Changeset detected

Latest commit: 50319d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hectahertz hectahertz requested review from Copilot and removed request for siddharthkp March 18, 2025 18:46
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 18, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new notice prop to the SelectPanel component to render an informational, warning, or error message along with respective icons.

  • Adds a notice prop to SelectPanel with associated styling and icon mappings
  • Updates the component stories and changeset documentation to demonstrate and track the new feature

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
packages/react/src/SelectPanel/SelectPanel.features.stories.tsx Adds a new story "WithNotice" demonstrating the notice prop functionality
.changeset/slick-teams-check.md Updates the changeset to reflect a minor release for the notice feature
packages/react/src/SelectPanel/SelectPanel.tsx Implements the notice prop functionality within the SelectPanel component
Files not reviewed (1)
  • packages/react/src/SelectPanel/SelectPanel.module.css: Language not supported

Tip: Turn on automatic Copilot reviews for this repository to get quick feedback on every pull request. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.38 KB (+0.34% 🔺)
packages/react/dist/browser.umd.js 105.74 KB (+0.37% 🔺)

@hectahertz hectahertz requested a review from TylerJDev March 18, 2025 18:55
@github-actions github-actions bot requested a deployment to storybook-preview-5790 March 18, 2025 18:55 Abandoned
@francinelucca
Copy link
Member

@emilybrick can we get design review on this? 🙏

Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking so good! some minor details.
Also let's make sure we run integration tests 🙏

Copy link
Contributor

@emilybrick emilybrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually LGTM. ✨

Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hectahertz hectahertz added this pull request to the merge queue Mar 21, 2025
Merged via the queue into main with commit acc5d27 Mar 21, 2025
44 checks passed
@hectahertz hectahertz deleted the hectahertz/select-panel-add-notice branch March 21, 2025 12:48
@primer primer bot mentioned this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants