-
Notifications
You must be signed in to change notification settings - Fork 646
Add Notice to SelectPanel #5790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 50319d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new notice prop to the SelectPanel component to render an informational, warning, or error message along with respective icons.
- Adds a notice prop to SelectPanel with associated styling and icon mappings
- Updates the component stories and changeset documentation to demonstrate and track the new feature
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react/src/SelectPanel/SelectPanel.features.stories.tsx | Adds a new story "WithNotice" demonstrating the notice prop functionality |
| .changeset/slick-teams-check.md | Updates the changeset to reflect a minor release for the notice feature |
| packages/react/src/SelectPanel/SelectPanel.tsx | Implements the notice prop functionality within the SelectPanel component |
Files not reviewed (1)
- packages/react/src/SelectPanel/SelectPanel.module.css: Language not supported
Tip: Turn on automatic Copilot reviews for this repository to get quick feedback on every pull request. Learn more
size-limit report 📦
|
|
@emilybrick can we get design review on this? 🙏 |
francinelucca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking so good! some minor details.
Also let's make sure we run integration tests 🙏
emilybrick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visually LGTM. ✨
francinelucca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
Closes https://github.com/github/primer/issues/4114
Changelog
New
Adds the
noticeprop toSelectPanelthat renders an info/warning/error message to the user.Rollout strategy
Testing & Reviewing
Merge checklist