Skip to content

Conversation

@jonrohan
Copy link
Member

@jonrohan jonrohan commented Mar 18, 2025

This PR removes the CSS modules feature flag from the Table component. The component Table and sub components are used 121 times in dotcom.

Closes https://github.com/github/primer/issues/4307

Changelog

New

Changed

Removed

Removes the CSS modules feature flag from the Table components.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Using Integration testing.

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2025

🦋 Changeset detected

Latest commit: 83fa205

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Mar 18, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.48 KB (0%)
packages/react/dist/browser.umd.js 104.86 KB (0%)

@jonrohan jonrohan changed the title Remove the CSS modules feature flag from Table chore(Table): Remove the CSS modules feature flag from the Table component Apr 4, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5788 April 4, 2025 23:59 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5788 April 5, 2025 00:13 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 5, 2025
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/371527

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Apr 10, 2025
@jonrohan jonrohan marked this pull request as ready for review April 10, 2025 21:22
@jonrohan jonrohan requested a review from a team as a code owner April 10, 2025 21:22
@jonrohan jonrohan added this pull request to the merge queue Apr 11, 2025
Merged via the queue into main with commit cd9987d Apr 11, 2025
45 checks passed
@jonrohan jonrohan deleted the remove_css_modules_flag_table branch April 11, 2025 16:39
@primer primer bot mentioned this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants