Skip to content

Conversation

@lukasoppermann
Copy link
Contributor

@lukasoppermann lukasoppermann commented Mar 14, 2025

Reverting icon color to fgColor-muted

The icon color in react is diverging from figma and rails. I assume this was missed while updating to css modules.

This PR adds the color for the icon on the blankslate component.

Closes #

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Reverting icon color to `fgColor-muted`
@lukasoppermann lukasoppermann requested a review from a team as a code owner March 14, 2025 13:18
@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2025

🦋 Changeset detected

Latest commit: 0c677c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukasoppermann lukasoppermann changed the title Update Blankslate.module.css Blankslate: Reverting icon color to fgColor-muted Mar 14, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 14, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@lukasoppermann lukasoppermann self-assigned this Mar 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 106.03 KB (0%)
packages/react/dist/browser.umd.js 106.38 KB (0%)

@github-actions github-actions bot requested a deployment to storybook-preview-5773 March 14, 2025 13:26 Abandoned
@primer primer bot requested a review from a team as a code owner March 14, 2025 14:44
@primer primer bot requested a review from maximedegreve March 14, 2025 14:44
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 14, 2025
@github-actions github-actions bot requested a deployment to storybook-preview-5773 March 14, 2025 14:47 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-5773 March 14, 2025 15:01 Inactive
@joshblack joshblack added this pull request to the merge queue Mar 14, 2025
Merged via the queue into main with commit 9e18567 Mar 14, 2025
44 checks passed
@joshblack joshblack deleted the lukasoppermann-blankslate-icon-color-fix branch March 14, 2025 15:39
@primer primer bot mentioned this pull request Mar 14, 2025
hectahertz pushed a commit that referenced this pull request Mar 20, 2025
Co-authored-by: Josh Black <[email protected]>
Co-authored-by: lukasoppermann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants