Skip to content

Remove CSS modules feature flag from SubNav #5772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 17, 2025
Merged

Remove CSS modules feature flag from SubNav #5772

merged 5 commits into from
Mar 17, 2025

Conversation

@jonrohan
Copy link
Member

@jonrohan jonrohan commented Mar 14, 2025 •
edited
Loading

This PR removes the CSS modules feature flag from the SubNav component. The component SubNav and SubNav.Link are used 0 times in dotcom.

Changelog

New

Changed

Removed

Removes the CSS modules feature flag from the SubNav component.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Using Integration testing.

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 3398069

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Mar 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.99 KB (-0.08% 🔽)
packages/react/dist/browser.umd.js 106.41 KB (+0.01% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5772 March 14, 2025 01:01 Inactive
@github-actions github-actions bot requested a deployment to storybook-preview-5772 March 17, 2025 20:33 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-5772 March 17, 2025 20:47 Inactive
@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Mar 17, 2025
@jonrohan jonrohan marked this pull request as ready for review March 17, 2025 20:54
@jonrohan jonrohan requested review from a team as code owners March 17, 2025 20:54
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 17, 2025
@jonrohan jonrohan changed the title Remove css modules feature flag from SubNav Remove CSS modules feature flag from SubNav Mar 17, 2025
@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 17, 2025
@primer-integration
Copy link

primer-integration bot commented Mar 17, 2025

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/367589

@primer-integration
Copy link

primer-integration bot commented Mar 17, 2025

🟢 golden-jobs completed with status success.

@jonrohan jonrohan requested a review from joshblack March 17, 2025 23:01
@jonrohan jonrohan added this pull request to the merge queue Mar 17, 2025
Merged via the queue into main with commit 0970415 Mar 17, 2025
45 checks passed
@jonrohan jonrohan deleted the css_modules_remove_flag_subnav branch March 17, 2025 23:22
@primer primer bot mentioned this pull request Mar 17, 2025
Merged
hectahertz pushed a commit that referenced this pull request Mar 20, 2025
@jonrohan @hectahertz
Remove CSS modules feature flag from SubNav (#5772)
dbc850b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblack joshblack joshblack approved these changes

@maximedegreve maximedegreve Awaiting requested review from maximedegreve maximedegreve was automatically assigned from primer/design-reviewers

@hectahertz hectahertz Awaiting requested review from hectahertz hectahertz is a code owner automatically assigned from primer/engineer-reviewers

Assignees

No one assigned

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonrohan @joshblack