Skip to content

Conversation

@siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Mar 11, 2025

Note


Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@siddharthkp siddharthkp self-assigned this Mar 11, 2025
@changeset-bot
Copy link

changeset-bot bot commented Mar 11, 2025

🦋 Changeset detected

Latest commit: 7113084

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Mar 11, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 106.13 KB (+0.08% 🔺)
packages/react/dist/browser.umd.js 106.42 KB (+0.09% 🔺)

@github-actions github-actions bot requested a deployment to storybook-preview-5759 March 11, 2025 14:46 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-5759 March 11, 2025 15:01 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5759 March 11, 2025 15:17 Inactive
@siddharthkp siddharthkp added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 11, 2025
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 11, 2025
@github-actions github-actions bot requested a deployment to storybook-preview-5759 March 11, 2025 15:57 Abandoned
@github-actions github-actions bot requested a deployment to storybook-preview-5759 March 11, 2025 16:05 Abandoned
@siddharthkp siddharthkp added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 11, 2025
@github-actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5759 March 13, 2025 20:08 Inactive
@siddharthkp siddharthkp requested review from langermank and removed request for tbenning March 13, 2025 20:19
@siddharthkp siddharthkp removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 13, 2025
/**
* Optional prop to set variant for narrow screen sizes
*/
variant?: ResponsiveValue<'anchored', 'anchored' | 'full-screen'>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
variant?: ResponsiveValue<'anchored', 'anchored' | 'full-screen'>
variant?: ResponsiveValue<'anchored', 'anchored' | 'fullscreen'>

Small suggestion.. for Dialog, we use fullscreen and I think it would be nice to align here for simplicity 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good note! Done

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 13, 2025
@github-actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 13, 2025
@github-actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 13, 2025
@siddharthkp
Copy link
Member Author

@langermank Ready for review again

@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 13, 2025
@github-actions github-actions bot requested a deployment to storybook-preview-5759 March 13, 2025 21:32 Abandoned
@siddharthkp siddharthkp disabled auto-merge March 13, 2025 21:45
@siddharthkp siddharthkp added this pull request to the merge queue Mar 13, 2025
Merged via the queue into main with commit 76bf60d Mar 13, 2025
45 checks passed
@siddharthkp siddharthkp deleted the responsive-anchored-overlay branch March 13, 2025 21:59
@primer primer bot mentioned this pull request Mar 13, 2025
hectahertz pushed a commit that referenced this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants