-
Notifications
You must be signed in to change notification settings - Fork 645
AnchoredOverlay: Add responsive variant prop #5759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 7113084 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
| /** | ||
| * Optional prop to set variant for narrow screen sizes | ||
| */ | ||
| variant?: ResponsiveValue<'anchored', 'anchored' | 'full-screen'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| variant?: ResponsiveValue<'anchored', 'anchored' | 'full-screen'> | |
| variant?: ResponsiveValue<'anchored', 'anchored' | 'fullscreen'> |
Small suggestion.. for Dialog, we use fullscreen and I think it would be nice to align here for simplicity 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good note! Done
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
|
@langermank Ready for review again |
Co-authored-by: siddharthkp <[email protected]>
Note
variantprop to AnchoredOverlay. It follows the same API style as other responsive variant props.Rollout strategy
Testing & Reviewing
Merge checklist