Skip to content

fix: user red focus state for inputs when in error state #5742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2025
Merged

fix: user red focus state for inputs when in error state #5742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96f5f9b
fix: user red focus state for inputs when in error state
francinelucca Mar 7, 2025
e693771
Create seven-chairs-act.md
francinelucca Mar 7, 2025
78e1778
update token
francinelucca Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/seven-chairs-act.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

fix: user red focus state for inputs when in error state
Copy link
Member

@joshblack joshblack Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fix: user red focus state for inputs when in error state
fix: use red focus state for inputs when in error state

28 changes: 14 additions & 14 deletions packages/react/src/__tests__/__snapshots__/Autocomplete.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@ exports[`snapshots renders a custom empty state message 1`] = `

.c0:where([data-validation='error']):where([data-trailing-action][data-focused]),
.c0:where([data-validation='error']):where(:not([data-trailing-action])):focus-within {
border-color: var(--fgColor-accent,var(--color-accent-fg,#0969da));
outline: 2px solid var(--fgColor-accent,var(--color-accent-fg,#0969da));
border-color: var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
outline: 2px solid var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
outline-offset: -1px;
}

Expand Down Expand Up @@ -392,8 +392,8 @@ exports[`snapshots renders a loading state 1`] = `

.c0:where([data-validation='error']):where([data-trailing-action][data-focused]),
.c0:where([data-validation='error']):where(:not([data-trailing-action])):focus-within {
border-color: var(--fgColor-accent,var(--color-accent-fg,#0969da));
outline: 2px solid var(--fgColor-accent,var(--color-accent-fg,#0969da));
border-color: var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
outline: 2px solid var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
outline-offset: -1px;
}

Expand Down Expand Up @@ -725,8 +725,8 @@ exports[`snapshots renders a menu that contains an item to add to the menu 1`] =

.c0:where([data-validation='error']):where([data-trailing-action][data-focused]),
.c0:where([data-validation='error']):where(:not([data-trailing-action])):focus-within {
border-color: var(--fgColor-accent,var(--color-accent-fg,#0969da));
outline: 2px solid var(--fgColor-accent,var(--color-accent-fg,#0969da));
border-color: var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
outline: 2px solid var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
outline-offset: -1px;
}

Expand Down Expand Up @@ -1687,8 +1687,8 @@ exports[`snapshots renders a multiselect input 1`] = `

.c0:where([data-validation='error']):where([data-trailing-action][data-focused]),
.c0:where([data-validation='error']):where(:not([data-trailing-action])):focus-within {
border-color: var(--fgColor-accent,var(--color-accent-fg,#0969da));
outline: 2px solid var(--fgColor-accent,var(--color-accent-fg,#0969da));
border-color: var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
outline: 2px solid var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
outline-offset: -1px;
}

Expand Down Expand Up @@ -2529,8 +2529,8 @@ exports[`snapshots renders a multiselect input with selected menu items 1`] = `

.c0:where([data-validation='error']):where([data-trailing-action][data-focused]),
.c0:where([data-validation='error']):where(:not([data-trailing-action])):focus-within {
border-color: var(--fgColor-accent,var(--color-accent-fg,#0969da));
outline: 2px solid var(--fgColor-accent,var(--color-accent-fg,#0969da));
border-color: var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
outline: 2px solid var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
outline-offset: -1px;
}

Expand Down Expand Up @@ -3559,8 +3559,8 @@ exports[`snapshots renders a single select input 1`] = `

.c0:where([data-validation='error']):where([data-trailing-action][data-focused]),
.c0:where([data-validation='error']):where(:not([data-trailing-action])):focus-within {
border-color: var(--fgColor-accent,var(--color-accent-fg,#0969da));
outline: 2px solid var(--fgColor-accent,var(--color-accent-fg,#0969da));
border-color: var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
outline: 2px solid var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
outline-offset: -1px;
}

Expand Down Expand Up @@ -4783,8 +4783,8 @@ exports[`snapshots renders with an input value 1`] = `

.c0:where([data-validation='error']):where([data-trailing-action][data-focused]),
.c0:where([data-validation='error']):where(:not([data-trailing-action])):focus-within {
border-color: var(--fgColor-accent,var(--color-accent-fg,#0969da));
outline: 2px solid var(--fgColor-accent,var(--color-accent-fg,#0969da));
border-color: var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
outline: 2px solid var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
outline-offset: -1px;
}

Expand Down
Loading
Loading