Skip to content

Conversation

@jamieshark
Copy link
Contributor

Towards https://github.com/github/primer/issues/3812

Changelog

New

Changed

FormControl feature flag is promoted to GA

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@jamieshark jamieshark requested a review from a team as a code owner March 5, 2025 20:22
@jamieshark jamieshark requested a review from jonrohan March 5, 2025 20:22
@changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2025

🦋 Changeset detected

Latest commit: c48141c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jamieshark jamieshark self-assigned this Mar 5, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@jamieshark jamieshark requested a review from hussam-i-am March 5, 2025 20:23
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.99 KB (-0.03% 🔽)
packages/react/dist/browser.umd.js 106.38 KB (-0.05% 🔽)

@jamieshark
Copy link
Contributor Author

waiting for #5717 to merge (cc: @jonrohan)

Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point this is the only component left not in ga. Seems like we could just go ahead and include in the latest #5717

But gonna leave that up to @francinelucca as RC

@francinelucca
Copy link
Member

Go for it 🔥

@joshblack joshblack added this pull request to the merge queue Mar 10, 2025
Merged via the queue into main with commit a4137bc Mar 10, 2025
44 checks passed
@joshblack joshblack deleted the jshark/form-control-ga branch March 10, 2025 16:45
@primer primer bot mentioned this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants