Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
5ccfe77
Moving Autocomplete to CSS modules ga flag
jonrohan Feb 19, 2025
216fe6c
Move AvatarStack from staff to ga feature flag
jonrohan Feb 19, 2025
4ba2818
Moving ConfirmationDialog to `primer_react_css_modules_ga` feature flag
jonrohan Feb 19, 2025
b0daba8
Moving DataTable to `primer_react_css_modules_ga` feature flag
jonrohan Feb 19, 2025
f37cd69
Moving UnderlinePanels to `primer_react_css_modules_ga` feature flag
jonrohan Feb 19, 2025
573e7d2
Moving InlineMessage to `primer_react_css_modules_ga` feature flag
jonrohan Feb 19, 2025
3f0b07f
Moving KeybindingHint to `primer_react_css_modules_ga` feature flag
jonrohan Feb 19, 2025
c136c9f
Moving NavList to `primer_react_css_modules_ga` feature flag
jonrohan Feb 19, 2025
3f30155
Moving Overlay to `primer_react_css_modules_ga` feature flag
jonrohan Feb 19, 2025
4e47a78
Moving PageHeader to `primer_react_css_modules_ga` feature flag
jonrohan Feb 19, 2025
303d05a
Moving PageLayout to `primer_react_css_modules_ga` feature flag
jonrohan Feb 19, 2025
82f1368
Moving Pagination to `primer_react_css_modules_ga` feature flag
jonrohan Feb 19, 2025
d78b62d
Moving SegmentedControl to `primer_react_css_modules_ga` feature flag
jonrohan Feb 19, 2025
40d39c0
Moving SelectPanel to `primer_react_css_modules_ga` feature flag
jonrohan Feb 19, 2025
833d3ad
Moving SubNav to `primer_react_css_modules_ga` feature flag
jonrohan Feb 19, 2025
d0b153f
Moving Token to `primer_react_css_modules_ga` feature flag
jonrohan Feb 19, 2025
f5d5202
Moving Tooltip to `primer_react_css_modules_ga` feature flag
jonrohan Feb 19, 2025
21ceb77
Moving BaseStyles to `primer_react_css_modules_ga` feature flag
jonrohan Feb 19, 2025
29cddd7
Moving SideNav to `primer_react_css_modules_ga` feature flag
jonrohan Feb 19, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/strong-cobras-refuse-1.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Moving AvatarStack to `primer_react_css_modules_ga` feature flag
5 changes: 5 additions & 0 deletions .changeset/strong-cobras-refuse-10.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Moving PageLayout to `primer_react_css_modules_ga` feature flag
5 changes: 5 additions & 0 deletions .changeset/strong-cobras-refuse-11.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Moving Pagination to `primer_react_css_modules_ga` feature flag
5 changes: 5 additions & 0 deletions .changeset/strong-cobras-refuse-12.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Moving SegmentedControl to `primer_react_css_modules_ga` feature flag
5 changes: 5 additions & 0 deletions .changeset/strong-cobras-refuse-13.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Moving SelectPanel to `primer_react_css_modules_ga` feature flag
5 changes: 5 additions & 0 deletions .changeset/strong-cobras-refuse-14.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Moving SubNav to `primer_react_css_modules_ga` feature flag
5 changes: 5 additions & 0 deletions .changeset/strong-cobras-refuse-15.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Moving Token to `primer_react_css_modules_ga` feature flag
5 changes: 5 additions & 0 deletions .changeset/strong-cobras-refuse-16.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Moving Tooltip to `primer_react_css_modules_ga` feature flag
5 changes: 5 additions & 0 deletions .changeset/strong-cobras-refuse-17.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Moving BaseStyles to `primer_react_css_modules_ga` feature flag
5 changes: 5 additions & 0 deletions .changeset/strong-cobras-refuse-18.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Moving SideNav to `primer_react_css_modules_ga` feature flag
5 changes: 5 additions & 0 deletions .changeset/strong-cobras-refuse-2.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Moving ConfirmationDialog to `primer_react_css_modules_ga` feature flag
5 changes: 5 additions & 0 deletions .changeset/strong-cobras-refuse-3.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Moving DataTable to `primer_react_css_modules_ga` feature flag
5 changes: 5 additions & 0 deletions .changeset/strong-cobras-refuse-4.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Moving UnderlinePanels to `primer_react_css_modules_ga` feature flag
5 changes: 5 additions & 0 deletions .changeset/strong-cobras-refuse-5.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Moving InlineMessage to `primer_react_css_modules_ga` feature flag
5 changes: 5 additions & 0 deletions .changeset/strong-cobras-refuse-6.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Moving KeybindingHint to `primer_react_css_modules_ga` feature flag
5 changes: 5 additions & 0 deletions .changeset/strong-cobras-refuse-7.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Moving NavList to `primer_react_css_modules_ga` feature flag
5 changes: 5 additions & 0 deletions .changeset/strong-cobras-refuse-8.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Moving Overlay to `primer_react_css_modules_ga` feature flag
5 changes: 5 additions & 0 deletions .changeset/strong-cobras-refuse-9.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Moving PageHeader to `primer_react_css_modules_ga` feature flag
5 changes: 5 additions & 0 deletions .changeset/strong-cobras-refuse.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Moving Autocomplete to `primer_react_css_modules_ga` feature flag
2 changes: 1 addition & 1 deletion packages/react/src/Autocomplete/AutocompleteMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ export type AutocompleteMenuInternalProps<T extends AutocompleteItemProps> = {
['aria-labelledby']: string
}

const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_staff'
const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_ga'

/**
* Announces a message to screen readers at a slowed-down rate. This is useful when you want to announce don't want to
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/Autocomplete/AutocompleteOverlay.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ function AutocompleteOverlay({
setShowMenu(false)
}, [setShowMenu])

const enabled = useFeatureFlag('primer_react_css_modules_staff')
const enabled = useFeatureFlag('primer_react_css_modules_ga')

if (typeof window === 'undefined') {
return null
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/AvatarStack/AvatarStack.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ type StyledAvatarStackWrapperProps = {
count?: number
} & SxProp

const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_staff'
const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_ga'

const AvatarStackWrapper = toggleStyledComponent(
CSS_MODULES_FEATURE_FLAG,
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/BaseStyles.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import classes from './BaseStyles.module.css'
// load polyfill for :focus-visible
import 'focus-visible'

const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_staff'
const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_ga'

const GlobalStyle = createGlobalStyle<{colorScheme?: 'light' | 'dark'}>`
* { box-sizing: border-box; }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export interface ConfirmationDialogProps {
confirmButtonType?: 'normal' | 'primary' | 'danger'
}

const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_staff'
const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_ga'

const StyledConfirmationHeader = toggleStyledComponent(
CSS_MODULES_FEATURE_FLAG,
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/DataTable/Table.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {toggleStyledComponent} from '../internal/utils/toggleStyledComponent'
import {Button} from '../internal/components/ButtonReset'
import classes from './Table.module.css'

const cssModulesFlag = 'primer_react_css_modules_staff'
const cssModulesFlag = 'primer_react_css_modules_ga'

// ----------------------------------------------------------------------------
// Table
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/InlineMessage/InlineMessage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import classes from './InlineMessage.module.css'
import type {SxProp} from '../sx'
type MessageVariant = 'critical' | 'success' | 'unavailable' | 'warning'

const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_staff'
const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_ga'

export type InlineMessageProps = React.ComponentPropsWithoutRef<'div'> &
SxProp & {
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/KeybindingHint/KeybindingHint.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {clsx} from 'clsx'

/** `kbd` element with style resets. */
const Kbd = ({children, className}: {children: ReactNode; className?: string}) => {
const enabled = useFeatureFlag('primer_react_css_modules_staff')
const enabled = useFeatureFlag('primer_react_css_modules_ga')

return (
<Text
Expand Down
10 changes: 5 additions & 5 deletions packages/react/src/NavList/NavList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export type NavListProps = {
} & SxProp &
React.ComponentProps<'nav'>

const NavBox = toggleStyledComponent('primer_react_css_modules_staff', 'nav', styled.nav<SxProp>(sx))
const NavBox = toggleStyledComponent('primer_react_css_modules_ga', 'nav', styled.nav<SxProp>(sx))

const Root = React.forwardRef<HTMLElement, NavListProps>(({children, ...props}, ref) => {
return (
Expand Down Expand Up @@ -70,7 +70,7 @@ export type NavListItemProps = {

const Item = React.forwardRef<HTMLAnchorElement, NavListItemProps>(
({'aria-current': ariaCurrent, children, defaultOpen, sx: sxProp = defaultSxProp, ...props}, ref) => {
const enabled = useFeatureFlag('primer_react_css_modules_staff')
const enabled = useFeatureFlag('primer_react_css_modules_ga')
const {depth} = React.useContext(SubNavContext)

// Get SubNav from children
Expand Down Expand Up @@ -161,7 +161,7 @@ function ItemWithSubNav({
}
}, [subNav, buttonId])

const enabled = useFeatureFlag('primer_react_css_modules_staff')
const enabled = useFeatureFlag('primer_react_css_modules_ga')
if (enabled) {
if (sxProp !== defaultSxProp) {
return (
Expand Down Expand Up @@ -255,7 +255,7 @@ const SubNavContext = React.createContext<{depth: number}>({depth: 0})
const SubNav = React.forwardRef(({children, sx: sxProp = defaultSxProp}: NavListSubNavProps, forwardedRef) => {
const {buttonId, subNavId, isOpen} = React.useContext(ItemWithSubNavContext)
const {depth} = React.useContext(SubNavContext)
const enabled = useFeatureFlag('primer_react_css_modules_staff')
const enabled = useFeatureFlag('primer_react_css_modules_ga')
if (!buttonId || !subNavId) {
// eslint-disable-next-line no-console
console.error('NavList.SubNav must be a child of a NavList.Item')
Expand Down Expand Up @@ -362,7 +362,7 @@ export type NavListGroupProps = {

const defaultSx = {}
const Group: React.FC<NavListGroupProps> = ({title, children, sx: sxProp = defaultSx, ...props}) => {
const enabled = useFeatureFlag('primer_react_css_modules_staff')
const enabled = useFeatureFlag('primer_react_css_modules_ga')

if (enabled) {
if (sxProp !== defaultSx) {
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/Overlay/Overlay.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {toggleStyledComponent} from '../internal/utils/toggleStyledComponent'
import classes from './Overlay.module.css'
import {clsx} from 'clsx'

const CSS_MODULES_FLAG = 'primer_react_css_modules_staff'
const CSS_MODULES_FLAG = 'primer_react_css_modules_ga'

type StyledOverlayProps = {
width?: keyof typeof widthMap
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/PageHeader/PageHeader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ const hiddenOnNarrow = {
wide: false,
}

const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_staff'
const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_ga'

// Root
// -----------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/PageLayout/PageLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export type PageLayoutProps = {
style?: React.CSSProperties
} & SxProp

const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_staff'
const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_ga'

const containerWidths = {
full: '100%',
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/Pagination/Pagination.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {useFeatureFlag} from '../FeatureFlags'
import {clsx} from 'clsx'
import classes from './Pagination.module.css'

const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_staff'
const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_ga'

const getViewportRangesToHidePages = (showPages: PaginationProps['showPages']) => {
if (showPages && typeof showPages !== 'boolean') {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {get} from '../constants'
import type {SegmentedControlButtonProps} from './SegmentedControlButton'

export const SEGMENTED_CONTROL_CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_staff'
export const SEGMENTED_CONTROL_CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_ga'

export const directChildLayoutAdjustments = {
':first-child': {
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/SelectPanel/SelectPanel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ export function SelectPanel({
}
}, [open, dataLoadedOnce, onFilterChange, filterValue, items, loadingManagedExternally, listContainerElement])

const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_staff'
const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_ga'
const enabled = useFeatureFlag(CSS_MODULES_FEATURE_FLAG)

const anchorRef = useProvidedRefOrCreate(externalAnchorRef)
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/SideNav.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {toggleStyledComponent} from './internal/utils/toggleStyledComponent'
import classes from './SideNav.module.css'
import {useFeatureFlag} from './FeatureFlags'

const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_staff'
const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_ga'

type SideNavBaseProps = {
as?: React.ElementType
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/SubNav/SubNav.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {useFeatureFlag} from '../FeatureFlags'

import styles from './SubNav.module.css'

const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_staff'
const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_ga'

type StyledSubNavProps = React.ComponentProps<'nav'> & {
actions?: React.ReactNode
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/Token/AvatarToken.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface AvatarTokenProps extends TokenBaseProps {
avatarSrc: string
}

const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_staff'
const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_ga'

const AvatarContainer = toggleStyledComponent(
CSS_MODULES_FEATURE_FLAG,
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/Token/IssueLabelToken.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export interface IssueLabelTokenProps extends TokenBaseProps {
fillColor?: string
}

const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_staff'
const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_ga'
const tokenBorderWidthPx = 1

const lightModeStyles = {
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/Token/Token.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export interface TokenProps extends TokenBaseProps, SxProp {
leadingVisual?: React.ElementType
}

const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_staff'
const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_ga'

const tokenBorderWidthPx = 1

Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/Token/TokenBase.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ const variants = variant<
},
})

const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_staff'
const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_ga'

const StyledTokenBase = toggleStyledComponent(
CSS_MODULES_FEATURE_FLAG,
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/Token/_RemoveTokenButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ interface TokenButtonProps extends SxProp {
isParentInteractive?: boolean
}

const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_staff'
const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_ga'

const variants = variant<{height: string; width: string}, TokenSizeKeys>({
prop: 'size',
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/Token/_TokenTextContainer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import classes from './_TokenTextContainer.module.css'
import {useFeatureFlag} from '../FeatureFlags'
import {clsx} from 'clsx'

const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_staff'
const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_ga'

const StyledTokenTextContainer = toggleStyledComponent(
CSS_MODULES_FEATURE_FLAG,
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/TooltipV2/Tooltip.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {KeybindingHint, type KeybindingHintProps} from '../KeybindingHint'
import VisuallyHidden from '../_VisuallyHidden'
import useSafeTimeout from '../hooks/useSafeTimeout'

const CSS_MODULE_FEATURE_FLAG = 'primer_react_css_modules_staff'
const CSS_MODULE_FEATURE_FLAG = 'primer_react_css_modules_ga'

const animationStyles = `
animation-name: tooltip-appear;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import classes from './UnderlinePanels.module.css'
import {toggleStyledComponent} from '../../internal/utils/toggleStyledComponent'
import {clsx} from 'clsx'

const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_staff'
const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_ga'

export type UnderlinePanelsProps = {
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {clsx} from 'clsx'
// The gap between the list items. It is a constant because the gap is used to calculate the possible number of items that can fit in the container.
export const GAP = 8

const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_staff'
const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_ga'

const StyledComponentUnderlineWrapper = toggleStyledComponent(
CSS_MODULES_FEATURE_FLAG,
Expand Down
Loading