Skip to content

chore(Skeleton): Remove the CSS module feature flag from Skeleton #5461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2024
Merged

chore(Skeleton): Remove the CSS module feature flag from Skeleton #5461

merged 2 commits into from
Dec 19, 2024

Conversation

@jonrohan
Copy link
Member

@jonrohan jonrohan commented Dec 18, 2024 •
edited
Loading

Changelog

New

Changed

Removed

Remove the CSS module feature flag from Skeleton

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: c5c0374

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Dec 18, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 18, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5461 December 18, 2024 23:42 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.09 KB (-0.43% 🔽)
packages/react/dist/browser.umd.js 104.46 KB (-0.49% 🔽)

@primer-integration
Copy link

primer-integration bot commented Dec 19, 2024

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/355960

@primer-integration
Copy link

primer-integration bot commented Dec 19, 2024

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 19, 2024
@jonrohan jonrohan marked this pull request as ready for review December 19, 2024 18:09
@jonrohan jonrohan requested a review from a team as a code owner December 19, 2024 18:09
@jonrohan jonrohan requested a review from camertron December 19, 2024 18:09
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 19, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@jonrohan jonrohan removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 19, 2024
@jonrohan jonrohan added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 9bd2f79 Dec 19, 2024
44 checks passed
@jonrohan jonrohan deleted the css_modules_remove_skeleton branch December 19, 2024 22:58
@primer primer bot mentioned this pull request Dec 19, 2024
Merged
@francinelucca francinelucca mentioned this pull request Jan 6, 2025
Merged
@jonrohan jonrohan restored the css_modules_remove_skeleton branch January 8, 2025 23:40
@jonrohan jonrohan deleted the css_modules_remove_skeleton branch May 9, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hussam-i-am hussam-i-am hussam-i-am approved these changes

@camertron camertron Awaiting requested review from camertron camertron is a code owner automatically assigned from primer/engineer-reviewers

Assignees

No one assigned

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonrohan @hussam-i-am