Skip to content

feat(Autocomplete): Convert to CSS modules behind feature flag #5453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Dec 18, 2024
Merged

feat(Autocomplete): Convert to CSS modules behind feature flag #5453

merged 37 commits into from
Dec 18, 2024

Conversation

@hussam-i-am
Copy link
Contributor

@hussam-i-am hussam-i-am commented Dec 17, 2024 •
edited
Loading

Closes https://github.com/github/primer/issues/4303

Changelog

New

Changed

  • Converts to CSS modules behind feature flag for AutocompleteOverlay

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

francinelucca and others added 25 commits December 11, 2024 16:41
@francinelucca
test(AutoComplete): add e2e tests
0a05161
@francinelucca @github-actions
test(vrt): update snapshots
dcab809
@francinelucca
Merge branch 'main' into francinelucca/e2e-tests/autocomplete
44f93b0
@francinelucca
Merge branch 'main' into francinelucca/e2e-tests/autocomplete
14b8035
@francinelucca
Merge branch 'main' of github.com:primer/react into francinelucca/e2e…
328c4ac 
…-tests/autocomplete
@francinelucca
fix(Autocomplete): wait for full render before e2e testing
d886b2c
@francinelucca
Merge branch 'main' into francinelucca/e2e-tests/autocomplete
a92ebf0
@francinelucca @github-actions
test(vrt): update snapshots
b48bd0a
@randall-krauskopf
Merge branch 'main' into francinelucca/e2e-tests/autocomplete
8797722
@randall-krauskopf
fix dev storybook accessibility
06121c0
@randall-krauskopf
fix lint
a9b653a
@randall-krauskopf
fix theme related a11y errors
3cf65ba
@randall-krauskopf @github-actions
test(vrt): update snapshots
e0aec57
@randall-krauskopf
ignore color-contrast rule
1297e36
@randall-krauskopf
Merge branch 'francinelucca/e2e-tests/autocomplete' of https://github…
184d90f 
….com/primer/react into francinelucca/e2e-tests/autocomplete
@langermank
add aria-label to dialog
4251993
@langermank
fix tests maybe?
165a1ba
@langermank
remove playground snaps
563aafb
@langermank
Merge branch 'main' into francinelucca/e2e-tests/autocomplete
18391a7
@langermank @github-actions
test(vrt): update snapshots
afb924f
@langermank
retry mask
fd88234
@langermank
fix contrast failure
ab50cc7
@langermank
try to disable flaky test
481acc9
@langermank @github-actions
test(vrt): update snapshots
665b7e3
@hussam-i-am
feat(Autocomplete): Convert to CSS modules behind feature flag
f9b17ec
@hussam-i-am hussam-i-am self-assigned this Dec 17, 2024
@hussam-i-am hussam-i-am requested a review from a team as a code owner December 17, 2024 19:09
@hussam-i-am hussam-i-am requested a review from jonrohan December 17, 2024 19:09
@changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 5be57e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 17, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.33 KB (+0.04% 🔺)
packages/react/dist/browser.umd.js 103.67 KB (+0.01% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5453 December 17, 2024 19:13 Inactive
@hussam-i-am hussam-i-am requested a review from a team as a code owner December 17, 2024 22:44
@github-actions github-actions bot temporarily deployed to storybook-preview-5453 December 17, 2024 22:48 Inactive
langermank
langermank approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that was easy! 😂

@langermank
Copy link
Contributor

langermank commented Dec 18, 2024

Not sure if we should tackle these Box styles too, or do that later (maybe if we have a chunk of word dedicated to removing Box) https://github.com/primer/react/pull/5451/files#diff-9dcb6a16b513af6dc1d448d292d3bddc55c5ac493994342a07aca673980adce6

@hussam-i-am hussam-i-am added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit b07f806 Dec 18, 2024
42 checks passed
@hussam-i-am hussam-i-am deleted the hussam-i-am/css-modules-autocomplete branch December 18, 2024 03:44
@primer primer bot mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@langermank langermank langermank approved these changes

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan is a code owner automatically assigned from primer/engineer-reviewers

@emilybrick emilybrick Awaiting requested review from emilybrick emilybrick was automatically assigned from primer/design-reviewers

Assignees

@hussam-i-am hussam-i-am

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hussam-i-am @langermank @francinelucca @randall-krauskopf