Skip to content

Deprecate use of sx prop by deprecating the SxProp type definition #5443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 18, 2024
Merged

Deprecate use of sx prop by deprecating the SxProp type definition #5443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0d6dacc
Use DeprecatedSxProp instead of SxProp
jonrohan Dec 13, 2024
d63396e
Create few-coins-kick.md
jonrohan Dec 13, 2024
a47f72b
Fix typo in changeset description
jonrohan Dec 13, 2024
59605d5
Use SxProp and deprecate that instead
jonrohan Dec 18, 2024
30aadb3
Fix typo in changeset description
jonrohan Dec 18, 2024
ca0f8d1
Fix typo in changeset description
jonrohan Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/few-coins-kick.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": minor
---

Deprecate use of sx prop by deprecating the `SxProp` type definition
1 change: 1 addition & 0 deletions packages/react/src/sx.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ type CSSSelectorObject = {
export type BetterSystemStyleObject = BetterCssProperties | SystemStyleObject | CSSCustomProperties | CSSSelectorObject

export interface SxProp {
/** @deprecated Use CSS modules for styling instead */
sx?: BetterSystemStyleObject
}

Expand Down
Loading