Skip to content

fix(PageHeader): Correctly add display prop #5415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 12, 2024
Merged

fix(PageHeader): Correctly add display prop #5415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
78428ed
correctly add display prop
randall-krauskopf Dec 11, 2024
c9213ca
correctly update display prop for title
randall-krauskopf Dec 11, 2024
aadc559
Merge branch 'page-header-title-bug' of https://github.com/primer/rea…
randall-krauskopf Dec 11, 2024
daee425
re-add missing style component
randall-krauskopf Dec 11, 2024
686eae8
add :where selector
randall-krauskopf Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/clever-bears-jog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Fix display bug for `PageHeader` component title.
6 changes: 5 additions & 1 deletion packages/react/src/PageHeader/PageHeader.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,12 +161,16 @@

.Title {
/* using flex and order to display the title in the title area. */
display: flex;
display: block;
order: var(--title-area-region-order-title);
font-size: inherit;
font-weight: inherit;
}

.Title:where([data-hidden='true']) {
display: none;
}

.TrailingVisual {
/* using flex and order to display the trailing visual in the title area. */
display: flex;
Expand Down
1 change: 1 addition & 0 deletions packages/react/src/PageHeader/PageHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,7 @@ const Title: React.FC<React.PropsWithChildren<TitleProps>> = ({
<Heading
className={clsx(enabled && classes.Title, className)}
data-component="PH_Title"
data-hidden={hidden}
as={as}
style={style}
sx={
Expand Down
Loading