Skip to content

chore(SelectPanel): Move SelectPanel component css module feature flag to staff #5397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2024
Merged

chore(SelectPanel): Move SelectPanel component css module feature flag to staff #5397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e713a6
Move SelectPanel to staff
jonrohan Dec 6, 2024
cf05771
Create fuzzy-owls-dance.md
jonrohan Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fuzzy-owls-dance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Move Textarea component css module feature flag to staff
6 changes: 3 additions & 3 deletions packages/react/src/experimental/SelectPanel2/SelectPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import {useFeatureFlag} from '../../FeatureFlags'

import classes from './SelectPanel.module.css'

const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_team'
const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_staff'

const SelectPanelContext = React.createContext<{
title: string
Expand Down Expand Up @@ -232,7 +232,7 @@ const Panel: React.FC<SelectPanelProps> = ({
[internalOpen, anchorRef.current, dialogRef.current],
)

/*
/*
We want to cancel and close the panel when user clicks outside.
See decision log: https://github.com/github/primer/discussions/2614#discussioncomment-8544561
*/
Expand Down Expand Up @@ -468,7 +468,7 @@ const SelectPanelHeader: React.FC<React.ComponentPropsWithoutRef<'div'> & {onBac
data-description={description ? true : undefined}
data-on-back={onBack ? true : undefined}
>
{/* heading element is intentionally hardcoded to h1, it is not customisable
{/* heading element is intentionally hardcoded to h1, it is not customisable
see https://github.com/github/primer/issues/2578 for context
*/}
<Heading
Expand Down
Loading