Skip to content

Conversation

@hussam-i-am
Copy link
Contributor

Changelog

New

Changed

  • Update type and remove validationStatus from useFormControlForwardedProps since it is not a valid aria attribute

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@hussam-i-am hussam-i-am self-assigned this Dec 6, 2024
@hussam-i-am hussam-i-am requested a review from a team as a code owner December 6, 2024 16:50
@hussam-i-am hussam-i-am requested a review from jonrohan December 6, 2024 16:50
@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: fa492e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.64 KB (-0.03% 🔽)
packages/react/dist/browser.umd.js 103.99 KB (-0.03% 🔽)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/354044

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 6, 2024
@hussam-i-am hussam-i-am added this pull request to the merge queue Dec 6, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 6, 2024
…us (#5376)

* fix(useFormControlForwardedProps): do not pass through validationStatus

* Create kind-kiwis-crash.md

---------

Co-authored-by: Jon Rohan <[email protected]>
Merged via the queue into main with commit 167c8d4 Dec 6, 2024
42 checks passed
@hussam-i-am hussam-i-am deleted the hussam-i-am/fix-form-control-context branch December 6, 2024 19:40
@primer primer bot mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants