Skip to content

Conversation

@joshblack
Copy link
Member

Closes #5362
Closes https://github.com/github/primer/issues/4415

Update an invalid line-height value which was dividing a unitless number by a rem value.

Changelog

New

Changed

  • Update the line-height specified in Table to use unitless values

Removed

Rollout strategy

  • Patch release

@joshblack joshblack requested a review from a team as a code owner December 5, 2024 19:46
@joshblack joshblack requested a review from camertron December 5, 2024 19:46
@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 5, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.66 KB (0%)
packages/react/dist/browser.umd.js 104.01 KB (0%)

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: 0a8d2e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joshblack joshblack added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit 3e0fc7c Dec 6, 2024
42 checks passed
@joshblack joshblack deleted the joshblack-patch-1 branch December 6, 2024 19:36
@primer primer bot mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Invalid line-height CSS property for StyledTable

3 participants