Skip to content

Conversation

@langermank
Copy link
Contributor

@langermank langermank commented Dec 4, 2024

Prep for ActionList -> CSS Modules

Changelog

Test removals

Scary, you must think I'm losing it!

  • ActionList with trailing action is visually broken unless the semantic button FF is enabled, which it is not in production. I am wrapping this functionality into the CSS Modules FF and we will add back these stories when we are no longer comparing snapshots to default.
  • NavList "bad" example should not have a visual test

UI Bugs

All other changes are bugs I found while converting to CSS, or little things that help align the default VRT snapshots to the updated CSS version

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: 6bebe7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 4, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5358 December 5, 2024 00:01 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.84 KB (+0.08% 🔺)
packages/react/dist/browser.umd.js 104.13 KB (+0.03% 🔺)

@langermank langermank added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 5, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5358 December 5, 2024 00:26 Inactive
@langermank langermank changed the title Actionlist pre css fixes Pre-ActionList CSS Modules bug fixes Dec 5, 2024
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 5, 2024
@primer primer bot temporarily deployed to github-pages December 5, 2024 00:36 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5358 December 5, 2024 00:37 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/353686

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 5, 2024
@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

@langermank
Copy link
Contributor Author

The dotcom integration test failures appear to be unrelated to this PR 👍

@langermank langermank added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit b08f770 Dec 5, 2024
42 checks passed
@langermank langermank deleted the actionlist-pre-css-fixes branch December 5, 2024 20:48
@primer primer bot mentioned this pull request Dec 5, 2024
francinelucca added a commit that referenced this pull request Dec 5, 2024
francinelucca added a commit that referenced this pull request Dec 5, 2024
francinelucca added a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: failing Changes in this PR cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants