Skip to content

Conversation

@JelloBagel
Copy link
Contributor

@JelloBagel JelloBagel commented Dec 4, 2024

Closes https://github.com/github/primer/issues/4358

Changelog

Changed

  • Convert BaseStyles to CSS modules behind primer_react_css_modules_team feature flag

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: 0c6494f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 4, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.71 KB (-0.06% 🔽)
packages/react/dist/browser.umd.js 104.23 KB (+0.13% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5356 December 4, 2024 18:56 Inactive
@JelloBagel JelloBagel added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 4, 2024
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 4, 2024
@primer primer bot temporarily deployed to github-pages December 4, 2024 20:36 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5356 December 4, 2024 20:36 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5356 December 4, 2024 20:58 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5356 December 4, 2024 21:22 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5356 December 4, 2024 21:52 Inactive
@JelloBagel JelloBagel added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 4, 2024
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 4, 2024
@primer primer bot temporarily deployed to github-pages December 4, 2024 22:32 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5356 December 4, 2024 22:32 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5356 December 4, 2024 22:52 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5356 December 4, 2024 23:00 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5356 December 4, 2024 23:14 Inactive
@JelloBagel JelloBagel force-pushed the jellobagel-basestyles-css-modules branch from 7a133ed to 584547d Compare December 4, 2024 23:23
@github-actions github-actions bot temporarily deployed to storybook-preview-5356 December 4, 2024 23:26 Inactive
@JelloBagel JelloBagel marked this pull request as ready for review December 4, 2024 23:58
@JelloBagel JelloBagel requested a review from a team as a code owner December 4, 2024 23:58
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 5, 2024
@JelloBagel JelloBagel marked this pull request as draft December 5, 2024 00:41
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/353683

@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

@JelloBagel
Copy link
Contributor Author

JelloBagel commented Dec 5, 2024

Remaking to clean up PR: #5361

@JelloBagel JelloBagel closed this Dec 5, 2024
@JelloBagel JelloBagel deleted the jellobagel-basestyles-css-modules branch December 5, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: failing Changes in this PR cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants