Skip to content

Conversation

@joshblack
Copy link
Member

@joshblack joshblack commented Dec 2, 2024

Update FormControl sub-components to be easier to migrate to CSS modules.

Changelog

New

Changed

  • Update the following FormControl sub-components to a different styled component style:
    • Label
    • Caption
    • LeadingVisual
    • Validation

Removed

Rollout strategy

  • Minor release

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: dbd9e32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 2, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5342 December 3, 2024 16:30 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.91 KB (+0.18% 🔺)
packages/react/dist/browser.umd.js 104.33 KB (+0.27% 🔺)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/353326

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 3, 2024
@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

@joshblack joshblack requested a review from jonrohan December 3, 2024 17:56
@joshblack joshblack marked this pull request as ready for review December 3, 2024 17:56
@joshblack joshblack requested a review from a team as a code owner December 3, 2024 17:56
@github-actions github-actions bot temporarily deployed to storybook-preview-5342 December 3, 2024 17:58 Inactive
Merged via the queue into main with commit 39df71e Dec 4, 2024
43 checks passed
@joshblack joshblack deleted the refactor/form-control-css-1 branch December 4, 2024 16:42
@primer primer bot mentioned this pull request Dec 4, 2024
francinelucca added a commit that referenced this pull request Dec 5, 2024
francinelucca added a commit that referenced this pull request Dec 5, 2024
francinelucca added a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: failing Changes in this PR cause breaking changes in gh/gh staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants