fix(Popover): Update component to forward ref

[hussam-i-am]

Fixes the failing integration test related to ref forwarding in Popover:

Error:Error: Expected test not to call console.error().

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.

Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?

Check the render method of `ValidationErrorPopover`.
    at className (/workspace/github/node_modules/@primer/react/lib/Popover/Popover.js:34:3)
    at id (/workspace/github/ui/packages/validation-error-popover/ValidationErrorPopover.tsx:65:3)
    at div
[...truncated...]

Changelog

New

Changed

• Wraps Popover in a forwardRef function

Removed

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

[changeset-bot]

🦋 Changeset detected

Latest commit: a78d483

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

[github-actions]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	100.55 KB (-0.01% 🔽)
packages/react/dist/browser.umd.js	101.01 KB (-0.06% 🔽)

[francinelucca]

Thanks!