Skip to content

Conversation

@randall-krauskopf
Copy link
Contributor

@randall-krauskopf randall-krauskopf commented Nov 18, 2024

Changelog

New

Changed

  • Converts PageLayout to CSS modules behind feature flags

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2024

🦋 Changeset detected

Latest commit: efdfb32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 18, 2024
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 101.37 KB (+0.82% 🔺)
packages/react/dist/browser.umd.js 101.53 KB (+0.52% 🔺)

@hussam-i-am hussam-i-am self-assigned this Nov 18, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5306 November 19, 2024 21:59 Inactive
@hussam-i-am hussam-i-am changed the title Page layout css modules feat(PageLayout): Convert PageLayout to CSS modules behind feature flag Nov 19, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5306 November 20, 2024 03:31 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 20, 2024
@hussam-i-am hussam-i-am marked this pull request as ready for review November 20, 2024 17:58
@hussam-i-am hussam-i-am requested a review from a team as a code owner November 20, 2024 17:58
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/351887

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Nov 20, 2024
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 20, 2024
@github-actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poked around with controls in Storybook and it looks good 😄 I love how clean this CSS looks!

@hussam-i-am hussam-i-am added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 84c3e62 Nov 21, 2024
43 checks passed
@hussam-i-am hussam-i-am deleted the PageLayout-css-modules branch November 21, 2024 16:08
@primer primer bot mentioned this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants