Skip to content

feat(Popover): Convert Popover to CSS modules behind team feature flag #5300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 18, 2024
Merged

feat(Popover): Convert Popover to CSS modules behind team feature flag #5300

merged 9 commits into from
Nov 18, 2024

Conversation

@francinelucca
Copy link
Member

@francinelucca francinelucca commented Nov 15, 2024 •
edited
Loading

Closes https://github.com/github/primer/issues/4139

Changelog

New

  • Popover dev story to test sx and style props with VRT
  • Popover module css
  • Snapshots for new dev story

Changed

  • Refactor Popover e2e tests and add new dev story
  • Refactor Popover to use CSS modules when team feature flag is turned on

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@francinelucca francinelucca added status: wip update snapshots 🤖 Command that updates VRT snapshots on the pull request component: Popover labels Nov 15, 2024
@changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 3cdcda9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Nov 15, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 15, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 100.25 KB (+0.22% 🔺)
packages/react/dist/browser.umd.js 100.53 KB (+0.18% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5300 November 15, 2024 03:34 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 15, 2024
@primer primer bot temporarily deployed to github-pages November 15, 2024 03:42 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5300 November 15, 2024 03:42 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5300 November 15, 2024 03:57 Inactive
@primer-integration
Copy link

primer-integration bot commented Nov 15, 2024

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/351364

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 15, 2024
@primer-integration
Copy link

primer-integration bot commented Nov 15, 2024

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Nov 15, 2024
@francinelucca francinelucca marked this pull request as ready for review November 15, 2024 18:51
@francinelucca francinelucca requested review from a team as code owners November 15, 2024 18:51
jonrohan
jonrohan approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ✨

@francinelucca francinelucca added this pull request to the merge queue Nov 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 18, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5300 November 18, 2024 15:55 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@francinelucca francinelucca added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit 65802fc Nov 18, 2024
39 of 40 checks passed
@francinelucca francinelucca deleted the francinelucca/4139-update-popover-to-css-modules branch November 18, 2024 19:59
@primer primer bot mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonrohan jonrohan jonrohan approved these changes

@langermank langermank langermank approved these changes

Assignees

No one assigned

Labels

component: Popover integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member status: review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@francinelucca @jonrohan @langermank