Skip to content

Conversation

@hussam-i-am
Copy link
Contributor

@hussam-i-am hussam-i-am commented Nov 14, 2024

Closes https://github.com/github/primer/issues/4309

Changelog

New

Changed

  • Updates Dialog v2 to use CSS modules behind the feature flag

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@hussam-i-am hussam-i-am self-assigned this Nov 14, 2024
@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2024

🦋 Changeset detected

Latest commit: ab7a9ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 14, 2024
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 100.3 KB (+0.26% 🔺)
packages/react/dist/browser.umd.js 100.64 KB (+0.3% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5298 November 14, 2024 21:20 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 14, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5298 November 15, 2024 21:06 Inactive
@hussam-i-am hussam-i-am marked this pull request as ready for review November 15, 2024 21:14
@hussam-i-am hussam-i-am requested a review from a team as a code owner November 15, 2024 21:14
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/351317

Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍🏻

@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

@hussam-i-am hussam-i-am added this pull request to the merge queue Nov 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2024
@hussam-i-am hussam-i-am added this pull request to the merge queue Nov 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5298 November 18, 2024 16:57 Inactive
@hussam-i-am hussam-i-am added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit 3935811 Nov 18, 2024
43 checks passed
@hussam-i-am hussam-i-am deleted the hussam-i-am/dialog-v2-css-modules- branch November 18, 2024 18:39
@primer primer bot mentioned this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: failing Changes in this PR cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants