Skip to content

Conversation

@randall-krauskopf
Copy link
Contributor

@randall-krauskopf randall-krauskopf commented Nov 14, 2024

Closes https://github.com/github/primer/issues/4364

Changelog

Changed

Convert spinner component to css module behind feature flag

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2024

🦋 Changeset detected

Latest commit: 6f8cebe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 14, 2024
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.7 KB (-0.01% 🔽)
packages/react/dist/browser.umd.js 99.09 KB (+0.1% 🔺)

1 similar comment
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.7 KB (-0.01% 🔽)
packages/react/dist/browser.umd.js 99.09 KB (+0.1% 🔺)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/351191

@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 14, 2024
@randall-krauskopf randall-krauskopf changed the title feat(textArea): convert to css modules feat(Textarea): Convert Textarea to CSS module behind feature flag Nov 14, 2024
@randall-krauskopf randall-krauskopf marked this pull request as ready for review November 14, 2024 16:47
@randall-krauskopf randall-krauskopf requested a review from a team as a code owner November 14, 2024 16:47
@randall-krauskopf
Copy link
Contributor Author

The integration test is failing from unrelated changes that should be getting resolved in the next Primer deployment.

@jonrohan jonrohan added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit 912a0d7 Nov 15, 2024
45 checks passed
@jonrohan jonrohan deleted the textarea-css-modules branch November 15, 2024 21:24
@primer primer bot mentioned this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: failing Changes in this PR cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants