Skip to content

chore(Skeleton): Move Skeleton component from team to staff flag #5289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2024
+13 −5
Merged

chore(Skeleton): Move Skeleton component from team to staff flag #5289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f45cdc8
Move Skeleton component to staff feature flag
jonrohan Nov 13, 2024
6fe2407
Create old-weeks-matter.md
jonrohan Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/old-weeks-matter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Move Skeleton component from team to staff flag
1 change: 1 addition & 0 deletions packages/react/src/experimental/Skeleton/FeatureFlag.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export const CSS_MODULE_FLAG = 'primer_react_css_modules_staff'
3 changes: 2 additions & 1 deletion packages/react/src/experimental/Skeleton/SkeletonAvatar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import classes from './SkeletonAvatar.module.css'
import {clsx} from 'clsx'
import {useFeatureFlag} from '../../FeatureFlags'
import {merge} from '../../sx'
import {CSS_MODULE_FLAG} from './FeatureFlag'

export type SkeletonAvatarProps = Pick<AvatarProps, 'size' | 'square'> & {
/** Class name for custom styling */
Expand Down Expand Up @@ -39,7 +40,7 @@ export const SkeletonAvatar: React.FC<SkeletonAvatarProps> = ({
}) => {
const responsive = isResponsiveValue(size)
const cssSizeVars = {} as Record<string, string>
const enabled = useFeatureFlag('primer_react_css_modules_team')
const enabled = useFeatureFlag(CSS_MODULE_FLAG)
const avatarSx = responsive
? {
...getBreakpointDeclarations(
Expand Down
6 changes: 3 additions & 3 deletions packages/react/src/experimental/Skeleton/SkeletonBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {toggleStyledComponent} from '../../internal/utils/toggleStyledComponent'
import {clsx} from 'clsx'
import classes from './SkeletonBox.module.css'
import {useFeatureFlag} from '../../FeatureFlags'
import {CSS_MODULE_FLAG} from './FeatureFlag'

type SkeletonBoxProps = {
/** Height of the skeleton "box". Accepts any valid CSS `height` value. */
Expand All @@ -22,10 +23,9 @@ const shimmer = keyframes`
from { mask-position: 200%; }
to { mask-position: 0%; }
`
const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_team'

const StyledSkeletonBox = toggleStyledComponent(
CSS_MODULES_FEATURE_FLAG,
CSS_MODULE_FLAG,
'div',
styled.div<SkeletonBoxProps>`
animation: ${shimmer};
Expand Down Expand Up @@ -56,7 +56,7 @@ export const SkeletonBox = React.forwardRef<HTMLDivElement, SkeletonBoxProps>(fu
{height, width, className, style, ...props},
ref,
) {
const enabled = useFeatureFlag(CSS_MODULES_FEATURE_FLAG)
const enabled = useFeatureFlag(CSS_MODULE_FLAG)
return (
<StyledSkeletonBox
height={enabled ? undefined : height}
Expand Down
3 changes: 2 additions & 1 deletion packages/react/src/experimental/Skeleton/SkeletonText.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import classes from './SkeletonText.module.css'
import {useFeatureFlag} from '../../FeatureFlags'
import {clsx} from 'clsx'
import {merge} from '../../sx'
import {CSS_MODULE_FLAG} from './FeatureFlag'

type SkeletonTextProps = {
/** Size of the text that the skeleton is replacing. */
Expand Down Expand Up @@ -80,7 +81,7 @@ export const SkeletonText: React.FC<SkeletonTextProps> = ({
style,
...rest
}) => {
const enabled = useFeatureFlag('primer_react_css_modules_team')
const enabled = useFeatureFlag(CSS_MODULE_FLAG)

if (lines < 2) {
return (
Expand Down
Loading