Skip to content

feat(TextInput): Convert TextInput (Part 1) - Deprecate width props #5253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 13, 2024
Merged

feat(TextInput): Convert TextInput (Part 1) - Deprecate width props #5253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7e74223
feat(TextInput): Remove width props from TextInput
hussam-i-am Nov 8, 2024
1958184
type fixes
hussam-i-am Nov 8, 2024
de2b18f
Merge branch 'main' into hussam-i-am/remove-textinput-width-props
hussam-i-am Nov 8, 2024
95c0827
Merge branch 'main' of https://github.com/primer/react into hussam-i-…
hussam-i-am Nov 8, 2024
a2fd736
lint fix
hussam-i-am Nov 8, 2024
5d36dd7
Merge branch 'hussam-i-am/remove-textinput-width-props' of https://gi…
hussam-i-am Nov 8, 2024
f64022b
remove unused imports
hussam-i-am Nov 8, 2024
75a2a67
Merge branch 'main' into hussam-i-am/remove-textinput-width-props
hussam-i-am Nov 12, 2024
4c64a6c
Merge branch 'main' into hussam-i-am/remove-textinput-width-props
hussam-i-am Nov 12, 2024
ca14ee3
Merge branch 'main' into hussam-i-am/remove-textinput-width-props
hussam-i-am Nov 13, 2024
a97371d
Merge branch 'main' into hussam-i-am/remove-textinput-width-props
hussam-i-am Nov 13, 2024
7a9493b
Update to deprecate props
hussam-i-am Nov 13, 2024
d7deba0
Properly mark props as deprecated
hussam-i-am Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/clean-ligers-approve.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": minor
---

Deprecate width, minWidth and maxWidth props from TextInput
13 changes: 8 additions & 5 deletions packages/react/src/internal/components/TextInputWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import styled, {css} from 'styled-components'
import type {MaxWidthProps, MinWidthProps, WidthProps} from 'styled-system'
import type {ResponsiveValue} from 'styled-system'
import {maxWidth, minWidth, variant, width} from 'styled-system'
import {get} from '../../constants'
import type {SxProp} from '../../sx'
Expand Down Expand Up @@ -56,10 +56,13 @@ export type StyledBaseWrapperProps = {
isInputFocused?: boolean
monospace?: boolean
validationStatus?: FormValidationStatus
} & WidthProps &
MinWidthProps &
MaxWidthProps &
SxProp
/** @deprecated Update `width` using CSS modules or style. */
width?: string | number | ResponsiveValue<string | number>
/** @deprecated Update `min-width` using CSS modules or style. */
minWidth?: string | number | ResponsiveValue<string | number>
/** @deprecated Update `max-width` using CSS modules or style. */
maxWidth?: string | number | ResponsiveValue<string | number>
} & SxProp

export type StyledWrapperProps = {
hasLeadingVisual?: boolean
Expand Down
Loading