Skip to content

fix(TextInput): Fix font size for small text inputs #5243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 6, 2024
Merged

fix(TextInput): Fix font size for small text inputs #5243

merged 4 commits into from
Nov 6, 2024

Conversation

@hussam-i-am
Copy link
Contributor

@hussam-i-am hussam-i-am commented Nov 6, 2024

Changelog

New

Changed

  • The media query styling was overriding the small variants, so updated the fontSize to be a responsive array to ensure it is correctly set

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@hussam-i-am hussam-i-am self-assigned this Nov 6, 2024
@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: f43c477

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 6, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5243 November 6, 2024 18:43 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.68 KB (+0.1% 🔺)
packages/react/dist/browser.umd.js 98.96 KB (+0.03% 🔺)

@hussam-i-am hussam-i-am added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 6, 2024
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 6, 2024
@hussam-i-am hussam-i-am marked this pull request as ready for review November 6, 2024 19:28
@hussam-i-am hussam-i-am requested review from a team as code owners November 6, 2024 19:28
langermank
langermank approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual change looks good, curious about the empty media queries but maybe it doesn't matter for now?

packages/react/src/__tests__/__snapshots__/TextInput.test.tsx.snap
}
@media screen and (min-width:544px) {
Copy link
Contributor

@langermank langermank Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why these were added? 🤔

Copy link
Contributor Author

@hussam-i-am hussam-i-am Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, seemed strange but noticed they already existed and so I figured it was some artifact of using styled components.

@hussam-i-am hussam-i-am added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit bc9c696 Nov 6, 2024
43 checks passed
@hussam-i-am hussam-i-am deleted the hussam-i-am/fix-text-input-font-size branch November 6, 2024 20:08
@primer primer bot mentioned this pull request Nov 6, 2024
Merged
@siddharthkp siddharthkp mentioned this pull request Nov 8, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@langermank langermank langermank approved these changes

@emilybrick emilybrick Awaiting requested review from emilybrick emilybrick is a code owner automatically assigned from primer/design-reviewers

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan is a code owner automatically assigned from primer/engineer-reviewers

Assignees

@hussam-i-am hussam-i-am

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TextInput: Value/Placeholder font size doesn't respect it's size variant

3 participants

@hussam-i-am @langermank