Skip to content

fix(Blankslate): update styles to center description text #5229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 5, 2024
Merged

fix(Blankslate): update styles to center description text #5229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cd77275
fix(Blankslate): update styles to center description text
joshblack Nov 4, 2024
97e8537
chore: add changeset
joshblack Nov 4, 2024
b98ab14
test(vrt): update snapshots
joshblack Nov 4, 2024
f7ea90f
refactor: apply text-align to Header, Description classes
joshblack Nov 5, 2024
e325c08
Merge branch 'fix/update-blankslate-to-center-text' of github.com:pri…
joshblack Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/odd-singers-hammer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Update Blankslate description text to always be centered
Binary file modified ...nents/Blankslate.test.ts-snapshots/Blankslate-Default-dark-colorblind-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...omponents/Blankslate.test.ts-snapshots/Blankslate-Default-dark-dimmed-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ts/Blankslate.test.ts-snapshots/Blankslate-Default-dark-high-contrast-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...shots/components/Blankslate.test.ts-snapshots/Blankslate-Default-dark-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...nents/Blankslate.test.ts-snapshots/Blankslate-Default-dark-tritanopia-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ents/Blankslate.test.ts-snapshots/Blankslate-Default-light-colorblind-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...s/Blankslate.test.ts-snapshots/Blankslate-Default-light-high-contrast-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...hots/components/Blankslate.test.ts-snapshots/Blankslate-Default-light-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ents/Blankslate.test.ts-snapshots/Blankslate-Default-light-tritanopia-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../Blankslate.test.ts-snapshots/Blankslate-Default-primer-breakpoint-sm-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../Blankslate.test.ts-snapshots/Blankslate-Default-primer-breakpoint-xs-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...onents/Blankslate.test.ts-snapshots/Blankslate-Narrow-dark-colorblind-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...components/Blankslate.test.ts-snapshots/Blankslate-Narrow-dark-dimmed-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...nts/Blankslate.test.ts-snapshots/Blankslate-Narrow-dark-high-contrast-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...pshots/components/Blankslate.test.ts-snapshots/Blankslate-Narrow-dark-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...onents/Blankslate.test.ts-snapshots/Blankslate-Narrow-dark-tritanopia-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...nents/Blankslate.test.ts-snapshots/Blankslate-Narrow-light-colorblind-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ts/Blankslate.test.ts-snapshots/Blankslate-Narrow-light-high-contrast-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...shots/components/Blankslate.test.ts-snapshots/Blankslate-Narrow-light-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...nents/Blankslate.test.ts-snapshots/Blankslate-Narrow-light-tritanopia-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...s/Blankslate.test.ts-snapshots/Blankslate-Narrow-primer-breakpoint-sm-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions packages/react/src/Blankslate/Blankslate.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
.Description {
margin: 0;
margin-bottom: var(--base-size-8);
text-align: center;
}

.Heading {
Expand Down
Loading