Skip to content

Conversation

@jonrohan
Copy link
Member

@jonrohan jonrohan commented Nov 4, 2024

Closes https://github.com/github/primer/issues/4296

Changelog

Changed

Convert Tooltip to CSS modules behind team flag

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2024

🦋 Changeset detected

Latest commit: 72bc2ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Nov 4, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 4, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5228 November 4, 2024 22:35 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5228 November 4, 2024 23:09 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5228 November 7, 2024 18:05 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5228 November 7, 2024 18:26 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.5 KB (+0.1% 🔺)
packages/react/dist/browser.umd.js 98.8 KB (+0.14% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5228 November 7, 2024 18:57 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/350441

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 7, 2024
@jonrohan jonrohan marked this pull request as ready for review November 7, 2024 20:52
@jonrohan jonrohan requested a review from a team as a code owner November 7, 2024 20:52
@jonrohan jonrohan added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit 2da7336 Nov 7, 2024
43 checks passed
@jonrohan jonrohan deleted the css_modules_tooltip branch November 7, 2024 23:14
@primer primer bot mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants